hypervisor: mshv: Complete guest boot support for ARM64 #7055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently PPI interrupt ID are hardcoded as numbers, it would be ideal to define them as constants and could be reused in other parts of the hypervisor crate. Signed-off-by: Jinank Jain <[email protected]>
Since this would be used in other places inside the hypervisor and hypervisor crate cannot take a dependency on arch crate, as that creates cyclic dependency. Signed-off-by: Jinank Jain <[email protected]>
liuw
reviewed
May 8, 2025
For ARM64 guests we need to set three important partition property: 1) PPI interrupt ID for timer interrupt 2) PPI interrupt ID for PMU interrupts. 3) Hiding LPI support from the guest because MSHV does emulate ITS for the guest. Signed-off-by: Jinank Jain <[email protected]>
For MSHV guests, we would need interrupt controller to be initialized before the VM gets initialized. This is because we are registering the base address of GIC distributor with MSHV as part of interrupt controller initialization workflow. And MSHV mandates that this property is set before we initialize the VM. Signed-off-by: Jinank Jain <[email protected]>
This will satisfy the requirement of MSHV i.e., setting the GICD base address before initializing the VM. Signed-off-by: Jinank Jain <[email protected]>
It just simplifies code and improves the code read-ability without much affecting the boot performance. Signed-off-by: Jinank Jain <[email protected]>
It seems like address allocation has been spread into different files and different location for x86 vs ARM. This makes it hard to follow the code. Thus, unify it a single location which satisfies all the requirement. Signed-off-by: Jinank Jain <[email protected]>
Num SPI and Base SPI nodes should be added before the end node to be included in the device tree generation. Fixes: eac44e6 (arch: Extend FDT for GICv2M device for ARM64 on MSHV) Signed-off-by: Jinank Jain <[email protected]>
Currently a lot of functions are stubbed out with unimplemented feature tag. Add the missing implementation to successfully boot ARM64 guests on MSHV. Signed-off-by: Jinank Jain <[email protected]>
liuw
approved these changes
May 9, 2025
Member
Author
|
@rbradford @likebreath It would be great if one of you could also take a look at this one? |
rbradford
approved these changes
May 9, 2025
Member
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
Code looks good overall with some potential nits.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
@rbradford Something changed in the CI getting this error: |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
I've fixed this. And it's running the job now - https://github.com/cloud-hypervisor/cloud-hypervisor/actions/runs/14931917110/job/41951078105 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
cloud-hypervisor:main
with commit May 9, 2025
8f40268
38 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series contains the final set of patches required to boot ARM64 guests on MSHV.