vmm: openapi: Remove path as required for DiskConfig
#7017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with our CLI syntax. The correctness of `DiskConfig` will be ensured via `VmConfig::validate()`, e.g. `path` and `socket` are mutually exclusive. Fixes: cloud-hypervisor#7016 Signed-off-by: Bo Chen <[email protected]>
liuw
approved these changes
Apr 5, 2025
jinankjain
approved these changes
Apr 7, 2025
Merged
via the queue into
cloud-hypervisor:main
with commit Apr 9, 2025
0e3733e
38 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with our CLI syntax. The correctness of
DiskConfigwill be ensured viaVmConfig::validate(), e.g.pathandsocketare mutually exclusive.Fixes: #7016