Introduce a fuzzer for x86 instruction emulator #6895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Liu <[email protected]>
liuw
force-pushed
the
fuzz-x86-insn-emulator
branch
from
39037ee to
04e6ffc
Compare
rbradford
approved these changes
Jan 2, 2025
likebreath
reviewed
Jan 2, 2025
Member
likebreath
left a comment
likebreath
left a comment
There was a problem hiding this comment.
Great addition to the fuzzer set we have. Only two nits below.
liuw
force-pushed
the
fuzz-x86-insn-emulator
branch
from
04e6ffc to
798dbd9
Compare
The fastfmt feature and VEX support use techniques that appear to leak memory in the eye of LLVM's address sanitizer. While at it, disable a bunch of instruction set decoding support we never intend to support. Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
This will become useful when we build the fuzzing target for the instruction emulator, because there is no need to pull in the rest of the hypervisor crate in that situation. Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
liuw
force-pushed
the
fuzz-x86-insn-emulator
branch
from
798dbd9 to
e81251d
Compare
likebreath
approved these changes
Jan 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruction decoding and emulation is complex. Introduce a fuzzer for it.
The fuzzer has found some issues in integer arithmetic. They are fixed in the same PR.