Fix bugs in VHDX code #6890
Merged
Fix bugs in VHDX code #6890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Liu <[email protected]>
The original code was buggy. It always attempted to update the header, even when the file was opened as read-only. That led to an error. The specification states that the headers should be updated when the first user visible write happens. We can just drop the incorrect code. Signed-off-by: Wei Liu <[email protected]>
The checksum field in the original buffer should be zeroed. The code was zeroing a temporary buffer. That's wrong. Signed-off-by: Wei Liu <[email protected]>
It doesn't need to be public. None of its code path returns an error. Signed-off-by: Wei Liu <[email protected]>
It doesn't make sense to open code the same calculation when there is already a helper function. Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
This is needed to handle multiple reads or writes in a loop. Signed-off-by: Wei Liu <[email protected]>
This was referenced Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues I discovered while trying to debug the SEG_MAX feature on VHDX.
All are fixed in this series.
I used QEMU as a reference. The image still works with QEMU after it's used by CH.