vmm: drop device_tree mutex before acquiring pci_bus mutex #6776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-matei
force-pushed
the
fix/move_bar_pci_resources_deadlock
branch
3 times, most recently
from
9db8938 to
b10aef7
Compare
Member
|
@alex-matei Please can you rebase your branch to capture the latest CI changes. |
AddressManager::move_bar() acquires the device_tree mutex. The function is called from PciConfigIo::config_space_write()/ PciConfigMmio::config_space_write() while the pci_bus mutex is acquired. The functions DeviceManager::pci_resources()/eject_device() acquire these mutexes in reverse order, which leads to a deadlock. Fixes: cloud-hypervisor#6775 Signed-off-by: Alexandru Matei <[email protected]>
alex-matei
force-pushed
the
fix/move_bar_pci_resources_deadlock
branch
from
b10aef7 to
5b1997b
Compare
Contributor
Author
|
@rbradford I rebased the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddressManager::move_bar() acquires the device_tree mutex. The function is called from PciConfigIo::config_space_write()/PciConfigMmio::config_space_write() while the pci_bus mutex is acquired.
The functions DeviceManager::pci_resources()/eject_device() acquire these mutexes in reverse order, which leads to a deadlock.
Fixes: #6775