vmm: fix resizing TTY consoles #6754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assignment of console_resize_pipe in the TTY case seems to have been accidentally deleted. I've put it back, but since this is adding code, I used the new safe API for checking whether a file is a terminal, introduced in Rust 1.70.0. We should probably use that everywhere, but that's out of scope of this bug fix. Fixes: 52eebaf ("vmm: refactor DeviceManager to use console_info") Signed-off-by: Alyssa Ross <[email protected]>
rbradford
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assignment of console_resize_pipe in the TTY case seems to have been accidentally deleted. I've put it back, but since this is adding code, I used the new safe API for checking whether a file is a terminal, introduced in Rust 1.70.0. We should probably use that everywhere, but that's out of scope of this bug fix.
Fixes: 52eebaf ("vmm: refactor DeviceManager to use console_info")