Pass the newly created console resizer pipe during vm reboot #6748
Conversation
|
@alyssais WDYT? |
|
Will take a look tomorrow. |
|
Code change looks right. Commit message doesn't fit Cloud Hypervisor's conventions. Is it on purpose that there's no space in the signoff / commit author metadata? (I see one in your GitHub display name.) |
|
@BharatNarasimman Please make sure to follow CONTRIBUTING.md and use |
BharatNarasimman
force-pushed
the
console_sigwinch
branch
2 times, most recently
from
cfe98e1 to
d1558f1
Compare
Thanks @rbradford @alyssais . I have amended the commit. |
Thanks. But I think it should be "vmm: ..." |
BharatNarasimman
force-pushed
the
console_sigwinch
branch
from
d1558f1 to
2b8a5c0
Compare
|
@alyssais - a question unrelated to this fix, |
|
Only the virtio-console device is resizable, not the serial one. At most one virtio-console device can exist, so there's never more than one resize pipe. |
|
|
Yes, that does look like a bug. Thank you. |
|
Could you rebase your commit onto main branch and then force push, it seems inappropriate to have 0b64aba in the commit history :) |
For a VM with virt-console enabled, when a reboot is requested, the console devices are closed during the shutdown path. As part of this the sigwinch listener process and the console resizer pipe are closed. For the new incarnation of the VM, fresh set of console devices are setup and a new console resizer pipe is created. The new VM should be setup to use the newly created console devices including the console resizer pipe. Reading from the older console resizer pipe results in unexpected eof error and terminates the cloud hypervisor process. Signed-off-by: BharatNarasimman <[email protected]>
BharatNarasimman
force-pushed
the
console_sigwinch
branch
from
bb49825 to
702993e
Compare
4 participants
For a VM with virt-console enabled, when a reboot is requested, the console devices are closed during the shutdown path. As part of this the sigwinch listener process and the console resizer pipe could be closed. For the new incarnation of the VM, fresh set of console devices are setup and a new console resizer pipe is created. The new VM should be setup to use the newly created console devices including the console resizer pipe.
Reading from the older console resizer pipe results in unexpected eof error and terminates the cloud hypervisor process.
cloud-hypervisor: 182.581732s: <__console> ERROR:virtio-devices/src/thread_helper.rs:55 -- Error running worker: HandleEvent(Failed to get resize event: Error { kind: UnexpectedEof, message: "failed to fill whole buffer" })