vmm: memory_manager: Fix bound checks for memory hotplug #6736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbradford
reviewed
Sep 18, 2024
Member
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
Looks correct to me. Thank you very much!
Member
|
Best to use |
yuhong-zhong
force-pushed
the
fix_mem_hotplug
branch
from
baab8d5 to
b69292b
Compare
Contributor
Author
|
@rbradford Thank you for the review! I've generated the SoB to fix it. |
Bound checks for virtio-mem and ACPI memory hotplug are off by one and two, respectively. This prevents users to fully use the reserved memory hotplug size. For ACPI, if we specific `--memory size=2G,hotplug_size=4G` and run `ch-remote resize --memory 6G`, cloud-hypervisor will report the following error because of the incorrect bound check: `<vmm> ERROR:vmm/src/lib.rs:1631 -- Error when resizing VM: MemoryManager(InsufficientHotplugRam)` Similarly, for virtio-mem, cloud-hypervisor will fail the incorrect bound check and abort the resize. The VM will see the following error in dmesg: `virtio_mem virtio3: unknown error, marking device broken: -22` This patch has fixed both bound checks and ensure that users can hot add memory up to the reserved hotplug size. Signed-off-by: Yuhong Zhong <[email protected]>
yuhong-zhong
force-pushed
the
fix_mem_hotplug
branch
from
b69292b to
fed804c
Compare
liuw
approved these changes
Sep 19, 2024
rbradford
approved these changes
Sep 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bound checks for virtio-mem and ACPI memory hotplug are off by one and two, respectively. This prevents users to fully use the reserved memory hotplug size.
For ACPI, if we specific
--memory size=2G,hotplug_size=4Gand runch-remote resize --memory 6G, cloud-hypervisor will report the following error because of the incorrect bound check:<vmm> ERROR:vmm/src/lib.rs:1631 -- Error when resizing VM: MemoryManager(InsufficientHotplugRam)Similarly, for virtio-mem, cloud-hypervisor will fail the incorrect bound check and abort the resize. The VM will see the following error in dmesg:
virtio_mem virtio3: unknown error, marking device broken: -22This patch has fixed both bound checks and ensure that users can hot add memory up to the reserved hotplug size.
Signed-off-by: Yuhong Zhong [email protected]