virtio-devices: support event idx for virtio-blk #6605
Conversation
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
Thank you for creating this PR and you work. Please review the contributing guide for correct commit message style.
Please also include the bug numbers as "Fixes: " in your commit message.
How have you tested this and and have you included testing with the rate limiter?
virtio-devices/src/block.rs
Outdated
| desc_chain | ||
| .memory() | ||
| .write_obj(VIRTIO_BLK_S_OK as u8, request.status_addr) | ||
| .write_obj(VIRTIO_BLK_S_OK, request.status_addr) |
There was a problem hiding this comment.
This change should not be in this PR - this change was recently made to fix an issue. Perhaps you could rebase and make sure this isn't included in this PR.
There was a problem hiding this comment.
I think that's something introduced by cargo fmt, already undo. May I know which issue is this change target to fix?
virtio-devices/src/block.rs
Outdated
| .store(write_avg, Ordering::Relaxed); | ||
|
|
||
| (VIRTIO_BLK_S_OK as u8, result as u32) | ||
| (VIRTIO_BLK_S_OK, result as u32) |
@rbradford Commit message has been updated. |
elainewu1222
force-pushed
the
support-virtio-blk-event-idx
branch
from
947cfef to
0781e20
Compare
I don't see any update in the commit message? Your changes should be squashed in your branch. |
elainewu1222
force-pushed
the
support-virtio-blk-event-idx
branch
from
29a1f95 to
919c8ea
Compare
@rbradford now the commit message should be good |
|
Your commit is lacking a SoB - "git commit --amend -s" will add it. |
Support event idx feature for virtio-blk device. This feature could improve disk IO performance by suppressing notifications from guest to host and interrupts from host to guest, which has been already supported in virtio-net and vhost-user devices. To achieve this, virtqueue's event-idx-related API is leveraged for avail_event field update and needs_notification check. Fixes: cloud-hypervisor#6580 Signed-off-by: wuxinyue <[email protected]>
elainewu1222
force-pushed
the
support-virtio-blk-event-idx
branch
from
919c8ea to
8f2f503
Compare
done |
2 participants
Support event idx feature for virtio-blk device.
This feature could improve disk IO performance by suppressing notifications from guest to host and interrupts from host to guest, which has been already supported in virtio-net and vhost-user devices.
To achieve this, virtqueue's event-idx-related API is leveraged for avail_event field update and needs_notification check.
Fixes: #6580