Add virtio-fs support #30

sboeuf · 2019-05-22T22:31:09Z

In order to support filesystem sharing between host and guest, this pull request introduces the support for vhost-user-fs (also known as virtio-fs) to its device model.

Fixes #9

sboeuf · 2019-05-22T22:32:08Z

Depends on:

rbradford

Not far off..I see the need to split up the commandline stuff.

vm-virtio/src/fs.rs

bjzhjing · 2019-05-24T02:29:02Z

@sboeuf Why don't you work based on vhost crate directly? Some differences there. If this work will be sent to upstream finally, I think change is needed, right?

sboeuf · 2019-05-24T15:07:37Z

@bjzhjing yes I need to rebase on top of vhost crate. The reason why I did this first was because I had a POC based off of vhost_user_rs crate and it was simpler to port. Also another reason is that vhost crate is not ready yet.

sboeuf · 2019-05-24T23:23:56Z

PR updated:

Added the support for the memory to be backed by a file from the command line --memory "size=256,file=/dev/shm"
Ported the code to the rust-vmm vhost crate (I had to submit a PR to fix a few things)

sboeuf · 2019-05-29T16:34:03Z

Updated on latest rust-vmm/vhost#2

sboeuf · 2019-06-14T20:55:55Z

@rbradford @sameo @chao-p
I updated the PR based on the PR rust-vmm/vm-memory#29, and also I copied the code from the pending PR rust-vmm/vhost#2 so that we don't depend on the non-existing vhost crate.

sameo · 2019-06-25T08:19:03Z

@sboeuf Are we waiting for a rust-vmm vm-memory PR to be merged here?

sboeuf · 2019-06-25T13:12:54Z

@sameo Yes we're waiting on rust-vmm/vm-memory#29. Maybe you can have a look at rust-vmm/vm-memory#29 if you have some spare time.

Remove legacy code coming from Firecracker and/or Crosvm. Signed-off-by: Sebastien Boeuf <[email protected]>

In order to avoid cloud-hypervisor to rely on a pending PR for the empty crate "vhost", this commit temporarily copies the content of the crate based on branch jiangliu/v1 18b5081d9199c76eca49da1971c9d1a65e53e5ff. Signed-off-by: Sebastien Boeuf <[email protected]>

The vhost-user-fs or virtio-fs device allows files and directories to be shared between host and guest. This patch adds the implementation of this device to the cloud-hypervisor device model. Signed-off-by: Sebastien Boeuf <[email protected]>

The user can now share some files and directories with the guest by providing the corresponding vhost-user socket. The virtiofsd daemon should be started by the user before to start the VM. Signed-off-by: Sebastien Boeuf <[email protected]>

In the context of vhost-user, we need the guest RAM to be backed by a file in order to be accessed by an external process. This patch adds the new flag "file=" to the "--memory" option so that we can specify from the command line if the memory needs to be backed, and by which specific file. Signed-off-by: Sebastien Boeuf <[email protected]>

This commit introduces the testing of the --fs option based on the virtio-fs implementation. This does not simply add a test, but also updates the integration script by generating a new kernel embedding the virtio-fs patches and by downloading the virtiofsd daemon. Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf · 2019-06-26T23:00:59Z

@sameo @chao-p This PR is updated and ready now that rust-vmm/vm-memory#29 has been merged :)

sameo

The PR looks good. 2 things I'd like to see improved:

Can we support multiple --fs from the command line?
Could you please add a short docs/fs.md document describing how to use that feature?

sameo · 2019-06-27T08:42:26Z

vmm/src/config.rs

-    pub rng: RngConfig<'a>,
    pub net: Option<NetConfig<'a>>,
+    pub rng: RngConfig<'a>,
+    pub fs: Option<FsConfig<'a>>,


I think it would make sense to support multiple shared directories, so we should have a vector of FsConfig here if possible.

sboeuf · 2019-06-27T14:57:53Z

@sameo yes let me address your comments and I'll repush asap.

Until now, the VMM was only accepting a single instance of a virtio-fs device. This commit extend the virtio-fs support by allowing several devices to be created for a single VM. Signed-off-by: Sebastien Boeuf <[email protected]>

Add some documentation specific to virtio-fs and how to perform filesystem sharing between host and guest with cloud-hypervisor. Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf · 2019-06-27T17:26:28Z

@sameo PR updated!

sboeuf changed the title ~~Add virtio-fs support~~ [WIP] Add virtio-fs support May 22, 2019

sboeuf requested review from chao-p, rbradford and sameo May 22, 2019 22:43

sboeuf force-pushed the add_virtiofs_support branch from 8613e78 to c87abcb Compare May 23, 2019 14:44

rbradford reviewed May 23, 2019

View reviewed changes

vm-virtio/src/fs.rs Show resolved Hide resolved

vm-virtio/src/fs.rs Show resolved Hide resolved

sboeuf force-pushed the add_virtiofs_support branch 3 times, most recently from eeaa603 to 8078b3f Compare May 23, 2019 23:46

sboeuf force-pushed the add_virtiofs_support branch from 8078b3f to ec4293e Compare May 24, 2019 18:41

sboeuf mentioned this pull request May 28, 2019

Facilitate the creation of file backed guest memory regions rust-vmm/vm-memory#20

Closed

sboeuf force-pushed the add_virtiofs_support branch from fb0bbc7 to 67c651f Compare May 29, 2019 16:33

sboeuf force-pushed the add_virtiofs_support branch from 67c651f to cbcf835 Compare May 31, 2019 23:17

sboeuf force-pushed the add_virtiofs_support branch from cbcf835 to b0b422d Compare June 14, 2019 20:46

sboeuf force-pushed the add_virtiofs_support branch 8 times, most recently from 621db21 to 9a86e98 Compare June 21, 2019 20:43

sboeuf changed the title ~~[WIP] Add virtio-fs support~~ Add virtio-fs support Jun 21, 2019

Sebastien Boeuf added 6 commits June 26, 2019 08:45

vm-virtio: Remove unneeded code

0e6d5de

Remove legacy code coming from Firecracker and/or Crosvm. Signed-off-by: Sebastien Boeuf <[email protected]>

vm-virtio: Add vhost-user-fs support

8cb1aa6

The vhost-user-fs or virtio-fs device allows files and directories to be shared between host and guest. This patch adds the implementation of this device to the cloud-hypervisor device model. Signed-off-by: Sebastien Boeuf <[email protected]>

vmm: Add virtio-fs support to the VMM

936ec01

The user can now share some files and directories with the guest by providing the corresponding vhost-user socket. The virtiofsd daemon should be started by the user before to start the VM. Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf force-pushed the add_virtiofs_support branch from 9a86e98 to e9c48fc Compare June 26, 2019 18:28

sameo reviewed Jun 27, 2019

View reviewed changes

Sebastien Boeuf added 2 commits June 27, 2019 09:14

vmm: Add support for multiple virtio-fs devices

6defecb

Until now, the VMM was only accepting a single instance of a virtio-fs device. This commit extend the virtio-fs support by allowing several devices to be created for a single VM. Signed-off-by: Sebastien Boeuf <[email protected]>

docs: Add virtio-fs documentation

cd4c755

Add some documentation specific to virtio-fs and how to perform filesystem sharing between host and guest with cloud-hypervisor. Signed-off-by: Sebastien Boeuf <[email protected]>

sameo approved these changes Jun 27, 2019

View reviewed changes

sameo merged commit c0336e8 into cloud-hypervisor:master Jun 27, 2019

sboeuf deleted the add_virtiofs_support branch December 5, 2019 07:12

phip1611 mentioned this pull request Nov 11, 2025

Speed up dirty_log() (a lot) #7468

Merged

1 task

Add virtio-fs support #30

Add virtio-fs support #30

Uh oh!

Conversation

sboeuf commented May 22, 2019

Uh oh!

sboeuf commented May 22, 2019

Uh oh!

rbradford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bjzhjing commented May 24, 2019

Uh oh!

sboeuf commented May 24, 2019

Uh oh!

sboeuf commented May 24, 2019

Uh oh!

sboeuf commented May 29, 2019

Uh oh!

sboeuf commented Jun 14, 2019

Uh oh!

sameo commented Jun 25, 2019

Uh oh!

sboeuf commented Jun 25, 2019

Uh oh!

sboeuf commented Jun 26, 2019

Uh oh!

sameo left a comment

Choose a reason for hiding this comment

Uh oh!

sameo Jun 27, 2019

Choose a reason for hiding this comment

Uh oh!

sboeuf commented Jun 27, 2019

Uh oh!

sboeuf commented Jun 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants