Add support for multiple disks #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the list of disks in a Vec<PathBuf> and then iterate over that when creating the block devices. Signed-off-by: Rob Bradford <[email protected]>
sboeuf
reviewed
May 22, 2019
README.md
Outdated
| $ popd | ||
| ``` | ||
|
|
||
| Multiple arguments can be given to the `--disk` parameter, currently the firmware requires that the bootable image is on the ffirst disk. |
sboeuf
reviewed
May 22, 2019
README.md
Outdated
| `cloud-hypervisor` supports direct kernel boot into a `vmlinux` ELF kernel image. | ||
| You want to build such image first: | ||
| `cloud-hypervisor` also supports direct kernel boot into a `vmlinux` ELF kernel | ||
| image. You want to build such image first: |
Member
There was a problem hiding this comment.
There are two spaces between . and You
sboeuf
approved these changes
May 22, 2019
Member
sboeuf
left a comment
sboeuf
left a comment
There was a problem hiding this comment.
Except two nits in the documentation, this change looks good to me.
We need to check that depending on the order we declare the disks from the command line, we get the expected /dev/vdX disks in the guest.
And fix the use of "also" that remained when the two sections on usage were flipped around. Signed-off-by: Rob Bradford <[email protected]>
Member
Author
They are in the order as specified on the command line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying multiple files with --disk
Fixes: #2