tests: Enable AArch64 CI with musl toolchain #1437
Conversation
MrXinWang
force-pushed
the
arm64_musl
branch
3 times, most recently
from
32e4366 to
821b65c
Compare
resources/Dockerfile
Outdated
| ln -s /usr/include/aarch64-linux-gnu/asm /usr/include/aarch64-linux-musl/asm \ | ||
| && ln -s /usr/include/asm-generic /usr/include/aarch64-linux-musl/asm-generic \ | ||
| && ln -s /usr/include/linux /usr/include/aarch64-linux-musl/linux \ | ||
| && mkdir /openssl-musl && wget https://github.com/openssl/openssl/archive/OpenSSL_1_1_1f.tar.gz \ |
There was a problem hiding this comment.
Wondering if we need to pin the specific version of openssl.
There was a problem hiding this comment.
Also do we need to update the version of Dockerfile again? This modification is also AArch64 only, even if we keep the version the same as before (i.e. v4), nothing will be broken.
|
Hi @sboeuf @rbradford, now this PR is ready for review. Previously the CI failed because of some additional crates (for example: I left some of my concerns in the review of myself. Would be more than happy to get some comments from you :) |
rbradford
left a comment
rbradford
left a comment
There was a problem hiding this comment.
Could you get away with only using musl to build the cloud-hypervisor binary but continue to use glibc for the test suite (i.e. the cargo tests) This would remove the need for the openssl hack?
@rbradford Yes I can confirm that without the openssl hack the musl toolchain can be used to build the cloud-hypervisor binary. If we only need to build the binary using musl, I am happy to remove the workaround I made. |
|
@MrXinWang Please proceed with that. We only need to build the cloud-hypervisor binary itself with the toolchain. |
This commit adds required environment configurations to the `dev_cli.sh` and a Jenkins stage to enable AArch64 binary building using musl toolchain. Signed-off-by: Henry Wang <[email protected]>
|
@rbradford Reversed the unit/integration test support code. PTAL. Thanks! |
3 participants
This commit adds a Jenkins stage to enable AArch64 CI with musl toolchain.
Signed-off-by: Henry Wang [email protected]