Support setting host MAC address #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this by reading the HW address information and then modifying the HW address to match the desired address. Preserving the rest of the state including the address type. Signed-off-by: Rob Bradford <[email protected]> Signed-off-by: Sebastien Boeuf <[email protected]>
This is necessary to support setting the MAC address on the tap interface on the host. Signed-off-by: Rob Bradford <[email protected]>
rbradford
force-pushed
the
2020-05-15-host-mac-addr
branch
2 times, most recently
from
42b5e8c to
0875bb6
Compare
Add a new "host_mac" parameter to "--net" and "--net-backend" and use this to set the MAC address on the tap interface. If no address is given one is randomly assigned and is stored in the config. Support for vhost-user-net self spawning was also included. Fixes: cloud-hypervisor#1177 Signed-off-by: Rob Bradford <[email protected]>
Extend the set of tests we have for virtio-net and vhost-user-net to check for host MAC address setting. Signed-off-by: Rob Bradford <[email protected]>
rbradford
force-pushed
the
2020-05-15-host-mac-addr
branch
from
0875bb6 to
b2a2f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide options to let the user choose their host MAC address. If the user does not provide one we generate one and store it in the config.
Fixes: #1177