disk/net/pmem unplug #1030
Merged
disk/net/pmem unplug #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than panic()ing when we get a kernel loading error populate the error upwards. Signed-off-by: Rob Bradford <[email protected]>
This id will be used to unplug the device if the user has chosen an id. Signed-off-by: Rob Bradford <[email protected]>
In order to support hotplugging there is a map of human readable device id to PCI BDF map. As the device id is part of the specific device configuration (e.g. NetConfig) it is necessary to return the id through from the helper functions that create the devices through to the functions that add those devices to the bus. This necessitates changing a great deal of function prototypes but otherwise has little impact. Currently only if an id is supplied by the user as part of the device configuration is it populated into this map. A later commit will populate with an autogenerated name where none is supplied by the user. Signed-off-by: Rob Bradford <[email protected]>
Add an accessor to return the underlying VirtioDevice. This is useful for managing the removal of the device from internal datastructures when handling virtio-pci device unplug. Signed-off-by: Rob Bradford <[email protected]>
Extend the eject_device() method on DeviceManager to also support virtio-pci devices being unplugged. Signed-off-by: Rob Bradford <[email protected]>
If the id has not been provided by the user generate an incrementing id. Signed-off-by: Rob Bradford <[email protected]>
We now support assigning device ids for VFIO and virtio-pci devices so this error can be generalised. Signed-off-by: Rob Bradford <[email protected]>
This ensures that a device that is removed will not reappear after a reboot. Signed-off-by: Rob Bradford <[email protected]>
Ensure that the device is removed and the removed device stays away after a reboot. Signed-off-by: Rob Bradford <[email protected]>
Ensure that the device is removed and the removed device stays away after a reboot. Signed-off-by: Rob Bradford <[email protected]>
sboeuf
approved these changes
Apr 16, 2020
| device_cfg.id = Some(id.clone()); | ||
| id | ||
| device_cfg.id = id.clone(); | ||
| id.unwrap() |
Member
Author
There was a problem hiding this comment.
@sboeuf Yes the previously the function returned a String which was then wrapped into a Some and saved with the plain String returned. Now it returns an Option<String> which is saved directly but the String needs to be returned so it needs to be unwrapped.
Member
Author
There was a problem hiding this comment.
We don't have to worry about None here as on the feature = "pci_support" case the function either errors or returns Some(..)
Member
|
@sameo PTAL |
sameo
approved these changes
Apr 16, 2020
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this pull request
Jul 16, 2020
With recent changes (cloud-hypervisor#1030 cloud-hypervisor#1084), the '/vm.remove-device' API is no longer restricted to remove VFIO PCI devices. It now supports (almost) all hotpluggable devices, e.g. disk/net/pmem/fs/vsock. Signed-off-by: Bo Chen <[email protected]>
sameo
pushed a commit
that referenced
this pull request
Jul 16, 2020
With recent changes (#1030 #1084), the '/vm.remove-device' API is no longer restricted to remove VFIO PCI devices. It now supports (almost) all hotpluggable devices, e.g. disk/net/pmem/fs/vsock. Signed-off-by: Bo Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support unplugging the same types of virtio-pci devices that we support for hotplug (disk, net and pmem)