Skip to content

Noisy virtio-pci ack_features warning on newer kernels #7414

@arachsys

Description

@arachsys

Since mainline linux commit torvalds/linux@69b9461, virtio pci can set all 128 feature bits, but cloud-hypervisor warns noisily when there are more than two 32-bit words in write_common_config_dword():

if self.driver_feature_select < 2 {
let mut locked_device = device.lock().unwrap();
locked_device
.ack_features(u64::from(value) << (self.driver_feature_select * 32));
} else {
warn!(
"invalid ack_features (page {}, value 0x{:x})",
self.driver_feature_select, value
);
}

Symptoms look like

cloud-hypervisor: 134.138928ms: <vcpu0> WARN:virtio-devices/src/transport/pci_common_config.rs:334 -- invalid ack_features (page 2, value 0x0)
cloud-hypervisor: 134.179294ms: <vcpu0> WARN:virtio-devices/src/transport/pci_common_config.rs:334 -- invalid ack_features (page 3, value 0x0)
cloud-hypervisor: 138.168374ms: <vcpu0> WARN:virtio-devices/src/transport/pci_common_config.rs:334 -- invalid ack_features (page 2, value 0x0)
cloud-hypervisor: 138.208690ms: <vcpu0> WARN:virtio-devices/src/transport/pci_common_config.rs:334 -- invalid ack_features (page 3, value 0x0)

on startup and occur on any mainline kernel after that commit, including the release 6.17 and stable 6.17.x kernels.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions