Stop shipping fipp with cider-nrepl #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
approved these changes
May 1, 2025
Member
bbatsov
left a comment
bbatsov
left a comment
There was a problem hiding this comment.
Looks good to me, but I guess we should document this somewhere. And mention it in the changelog as well.
Member
Author
|
I will describe it in CIDER docs, it has a section about (pretty-)?printing. |
alexander-yakushev
force-pushed
the
skip-fipp
branch
from
33dcea2 to
ef7bd33
Compare
alexander-yakushev
force-pushed
the
skip-fipp
branch
from
ef7bd33 to
cd74f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same way as Puget and zprint.
Additionally, default all three to
orchard.pp, our new pretty-printing implementation that is faster thanclojure.pprintand is also more consistent with the way we do printing in other parts of CIDER (inspector, debugger).