Merged
Conversation
Collaborator
Author
|
A few new things:
|
Collaborator
Author
|
Have now reorganized the code more and written documentation. There are new methods and that are called similarly to the existing So we preserve all existing functionality but make it simple to get the parameters we need to pass to radiation modules. WIP: supporting multiple time-averaging methods for the daily zenith angle. The function Still to do:
Then in a further PR I will work on adapting the Insolation process objects to handle all this new functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #208 (eventually).
So far the PR just refactors the insolation calculator into more reusable functions. Working toward a better and more consistent treatment of insolation internally within climlab.
coszenshould be elevated as the primary input to radiation processes, withinsolationbeing treated as a diagnostic.