Merged
Conversation
brian-rose
approved these changes
May 17, 2023
Collaborator
brian-rose
left a comment
brian-rose
left a comment
There was a problem hiding this comment.
Hi @HenryDane, thanks for this! The fix looks great. I didn't realize until now that #172 is really a duplicate of #74 which has been sitting open unresolved for years.
I really appreciate that you included appropriate tests with this PR. Great work, and thanks for the contributions!
This was
linked to
issues
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix climlab/main #74 and also fix climlab/main #172 .
Please let me know if you have any comments, feedback, or questions.