Can't independently specify insolation and solar zenith angle #208
Description
The radiation processes have three separate input parameters
S0insolationcoszen
Currently, if coszen is omitted then it gets assigned an inferred default value
coszen = insolation / S0
Only S0 and coszen are actually passed to the SW radiation drivers. So if the user sets a value for coszen then insolation is ignored. For example, this assertion fails:
import climlab
state = climlab.column_state()
# two models with factor of two difference in insolation
sw1 = climlab.radiation.RRTMG_SW(state=state, coszen=0.25, insolation=300.)
sw2 = climlab.radiation.RRTMG_SW(state=state, coszen=0.25, insolation=600.)
for process in [sw1, sw2]: process.compute_diagnostics()
assert sw1.ASR != sw2.ASR