Add cmake flags for Apple-clang case to cover C/C++ and RELEASE/REWITHDEBINFO builds#6
Merged
climbfuji merged 1 commit intoclimbfuji:bugfix/odc146_appleclang1403from May 19, 2023
srherbener:bugfix/odc-cmake-flags
Merged
Add cmake flags for Apple-clang case to cover C/C++ and RELEASE/REWITHDEBINFO builds#6climbfuji merged 1 commit intoclimbfuji:bugfix/odc146_appleclang1403from srherbener:bugfix/odc-cmake-flags
climbfuji merged 1 commit intoclimbfuji:bugfix/odc146_appleclang1403from
srherbener:bugfix/odc-cmake-flags
Conversation
…th release and relwithdebinfo builds and for both C and C++ source files.
Author
|
@climbfuji here is the PR with my fixes. For some reason I can't assign reviewers, but hopefully you can review and I'm happy to make changes if needed. I went ahead and added the RELEASE build case. Thanks! |
climbfuji
approved these changes
May 19, 2023
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds extra CMAKE defines to cover the
-O1workaround for [email protected] builds.