Remove ANSI color sequences when calculating width of display text#4066
Closed
Remove ANSI color sequences when calculating width of display text#4066
Conversation
mislav
reviewed
Aug 2, 2021
|
|
||
| // DisplayWidth calculates what the rendered width of a string may be | ||
| func DisplayWidth(s string) int { | ||
| s = reColorSequence.ReplaceAllString(s, "") |
Contributor
There was a problem hiding this comment.
Thank you for the straightforward fix!
Note that an older PR https://github.com/cli/cli/pull/3519/files#diff-7cd07c3defa4823b12484e616fc8cb5f63dc01e5a9df23544634b111a8d20547R15 also proposes ignoring ANSI escape sequences when measuring width of text, but uses a library that does this without a regular expression. I would personally vote for that approach since it might be computationally lighter. However, that PR isn't reviewed yet. Please allow us some time to decide how to proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4065
This PR fixes the example shown in the issue as follows:
The start positions of issue date column are aligned correctly.