Fix colors of left and right parens of issue label are different#4064
Closed
Fix colors of left and right parens of issue label are different#4064
Conversation
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
mislav
reviewed
Aug 2, 2021
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thank you, and good catch!
Fix looks good but the final fix is going to be dependent on #4065 (comment). Let's wait for resolution of that one first.
Author
|
Sure. Please feel free to close this if this fix is no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes small color issue on listing issues. Since the issue is very small, I made the fix and PR directly without making an issue.
Here are outputs of
gh issue listbefore/after this fix.Before (gh 1.13.1)
Left paren of issue labels is gray but right paren of issue labels is white.
After
Both parens are white.
Note
It is a bit difficult to make both parens gray because giving a color to right paren requires some hack. Issue labels are truncated when they are too long in
truncateLabelsfunction, but it truncates labels string without considering escape sequence.