fix: show checks summary when all checks were cancelled by s3onghyun · Pull Request #13679 · cli/cli

s3onghyun · 2026-06-18T12:37:27Z

Description

gh pr checks prints a blank summary when a PR's only checks were cancelled.

printSummary (pkg/cmd/pr/checks/output.go) gates the summary block on:

if counts.Failed+counts.Passed+counts.Skipping+counts.Pending > 0 {

counts.Canceled is omitted, so a cancelled-only result sums to 0, the block is skipped, and the else if counts.Canceled > 0 { "Some checks were cancelled" } branch becomes unreachable in exactly the case it was written for. The existing "some cancelled" test masked this by pairing a cancelled check with passing ones.

Fix

Add counts.Canceled to the guard.

Testing

Added TestPrintSummary (output_test.go) with a cancelled-only case asserting the "Some checks were cancelled" summary renders. Fails before, passes after; go test ./pkg/cmd/pr/checks/ green.

Reported in #13680.

printSummary gated the summary block on Failed+Passed+Skipping+Pending > 0, omitting Canceled. For a PR whose only checks were cancelled, the summary (and the 'Some checks were cancelled' message) was skipped, printing a blank line. Include Canceled in the guard. Signed-off-by: Seonghyun Hong <[email protected]>

github-actions · 2026-06-18T12:37:49Z

Thanks for your pull request! Unfortunately, it doesn't meet the requirements for review:

No linked help wanted issue found in PR description

Please update your PR to address the above. This PR will be automatically closed in 4 days if these requirements are not met.

Full contribution requirements

Include a detailed description of what this PR does
Link to an issue with the help wanted label (use Fixes #123 or Closes #123)

s3onghyun · 2026-06-18T12:43:04Z

I've opened #13680 describing the bug. This is a small, self-contained fix with a regression test, but I understand the contribution policy expects a triaged help wanted issue first — happy to wait for triage on #13680, and I'll re-link if needed. Thanks!

babakks

Thanks for the PR, @s3onghyun! 🙏

Changes look good. Just a few comments.

babakks · 2026-06-19T11:43:16Z

+	tests := []struct {
+		name   string
+		counts checkCounts
+		want   string
+	}{


Now that we're adding a test for printSummary, let's cover all code paths in the summary line if-statements, i.e.:

if counts.Failed+counts.Passed+counts.Skipping+counts.Pending+counts.Canceled > 0 { if counts.Failed > 0 { summary = "Some checks were not successful" } else if counts.Pending > 0 { summary = "Some checks are still pending" } else if counts.Canceled > 0 { summary = "Some checks were cancelled" } else { summary = "All checks were successful" }

babakks · 2026-06-19T11:46:47Z

+	// Regression guard: a check set containing only cancelled checks must still
+	// produce a summary. Before the fix, the guard in printSummary omitted
+	// counts.Canceled, so a cancelled-only result printed an empty summary.
+	t.Run("cancelled-only is not silently empty", func(t *testing.T) {
+		ios, _, stdout, _ := iostreams.Test()
+		ios.SetStdoutTTY(true)
+
+		printSummary(ios, checkCounts{Canceled: 1})
+
+		assert.Contains(t, stdout.String(), "Some checks were cancelled")
+	})


This is not needed. Please remove it.

Address review: expand TestPrintSummary to exercise every summary path (no checks, all successful, failed, pending, cancelled) and drop the redundant separate regression case. Signed-off-by: Seonghyun Hong <[email protected]>

s3onghyun · 2026-06-19T12:45:24Z

Thanks @babakks! Addressed both:

TestPrintSummary is now a table test covering every summary branch: no checks, all successful, some failed, some pending, and cancelled.
Removed the separate cancelled-only is not silently empty subtest — the table's "only cancelled" case (which fails on the pre-fix code) covers that regression.

go test ./pkg/cmd/pr/checks/ is green.

babakks

LGTM! Thanks for the changes, @s3onghyun! 🙏

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.94.0` → `v2.96.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.96.0`](https://github.com/cli/cli/releases/tag/v2.96.0): GitHub CLI 2.96.0 [Compare Source](cli/cli@v2.95.0...v2.96.0) #### Security A security vulnerability has been identified, and fixed, that could allow command execution on a user's computer when connecting to a malicious Codespace via `gh codespace jupyter`. Users of `gh codespace jupyter` are advised to update gh to version v2.96.0 as soon as possible. For more information see: <GHSA-8cg3-r6g9-fpg2> #### Download release assets without authentication `gh release download` now works against public repositories without authentication, matching `gh extension install`. A token is still used when one is present: ```shell # Download assets from a public repository, no login required gh release download v2.96.0 --repo cli/cli ``` #### What's Changed ##### ✨ Features - Allow `gh release download` without authentication on public repositories by [@BagToad](https://github.com/BagToad) in [#13723](cli/cli#13723) - Detect additional third-party coding agents by [@BagToad](https://github.com/BagToad) in [#13722](cli/cli#13722) - Support `antigravity-cli` and `antigravity2.0` in `gh skill` by [@BagToad](https://github.com/BagToad) in [#13784](cli/cli#13784) ##### 🐛 Fixes - fix: show checks summary when all checks were cancelled by [@s3onghyun](https://github.com/s3onghyun) in [#13679](cli/cli#13679) - fix(skills): install universal agent to `~/.agents/skills` by [@toller892](https://github.com/toller892) in [#13681](cli/cli#13681) - fix(skills): honor `--dir` without agent prompt by [@happysnaker](https://github.com/happysnaker) in [#13766](cli/cli#13766) - Fix concurrent map writes in codespace port forwarding by [@williammartin](https://github.com/williammartin) in [#13313](cli/cli#13313) - Use `int64` for GitHub database IDs by [@williammartin](https://github.com/williammartin) in [#13403](cli/cli#13403) ##### 📚 Docs & Chores - Pin reusable triage workflows to a commit SHA by [@BagToad](https://github.com/BagToad) in [#13705](cli/cli#13705) - Add security disclosure guidance to `AGENTS.md` by [@BagToad](https://github.com/BagToad) in [#13720](cli/cli#13720) - Clarify `--clone` boolean flag behaviour in `gh repo fork` help by [@BagToad](https://github.com/BagToad) in [#13786](cli/cli#13786) - Fix flaky `TestHuhPrompterMultiSelectWithSearchPersistence` on slow architectures by [@pdostal](https://github.com/pdostal) in [#13675](cli/cli#13675) - docs(search): add examples for multiple qualifiers by [@happysnaker](https://github.com/happysnaker) in [#13756](cli/cli#13756) - docs: fix broken anchor link in release-process-deep-dive by [@patrickwehbe](https://github.com/patrickwehbe) in [#13688](cli/cli#13688) - docs: fix broken install command and link/grammar errors by [@patrickwehbe](https://github.com/patrickwehbe) in [#13690](cli/cli#13690) - docs: fix duplicated word in primer README by [@s3onghyun](https://github.com/s3onghyun) in [#13677](cli/cli#13677) #####

Dependencies - chore(deps): bump github.com/microsoft/dev-tunnels from 0.1.19 to 0.1.27 by [@dependabot](https://github.com/dependabot) in [#13708](cli/cli#13708) - chore(deps): bump actions/checkout from 6.0.3 to 7.0.0 by [@dependabot](https://github.com/dependabot) in [#13703](cli/cli#13703) - chore(deps): bump github.com/google/go-containerregistry from 0.21.6 to 0.21.7 by [@dependabot](https://github.com/dependabot) in [#13702](cli/cli#13702) - chore(deps): bump actions/setup-go from 6.4.0 to 6.5.0 by [@dependabot](https://github.com/dependabot) in [#13740](cli/cli#13740) - chore(deps): bump actions/attest from 4.1.0 to 4.1.1 by [@dependabot](https://github.com/dependabot) in [#13754](cli/cli#13754) - chore(deps): bump goreleaser/goreleaser-action from 7.2.2 to 7.2.3 by [@dependabot](https://github.com/dependabot) in [#13759](cli/cli#13759) - chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0 by [@dependabot](https://github.com/dependabot) in [#13779](cli/cli#13779) #### New Contributors - [@patrickwehbe](https://github.com/patrickwehbe) made their first contribution in [#13688](cli/cli#13688) - [@s3onghyun](https://github.com/s3onghyun) made their first contribution in [#13679](cli/cli#13679) - [@toller892](https://github.com/toller892) made their first contribution in [#13681](cli/cli#13681) - [@happysnaker](https://github.com/happysnaker) made their first contribution in [#13756](cli/cli#13756) **Full Changelog**: <cli/cli@v2.95.0...v2.96.0> ### [`v2.95.0`](https://github.com/cli/cli/releases/tag/v2.95.0): GitHub CLI 2.95.0 [Compare Source](cli/cli@v2.94.0...v2.95.0) #### Read repository files and directories with `gh repo read-file` and `gh repo read-dir` Two new preview commands read repository contents without cloning: ```shell # Read a single file to stdout gh repo read-file README.md --repo cli/cli # Read from a specific branch, tag, or commit gh repo read-file go.mod --ref v2.94.0 --repo cli/cli # Write a file to disk (use --clobber to overwrite) gh repo read-file README.md --output ./README.md --repo cli/cli # List the entries in a directory gh repo read-dir script --repo cli/cli ``` Both commands default to the repository's default branch, accept `--ref` to target any branch, tag, or commit, and support `--json`, `--jq`, and `--template` for scripting. This makes it easy for agents and automation to inspect a repo without a full checkout. > \[!NOTE] > `gh repo read-file` and `gh repo read-dir` are in preview and subject to change without notice. #### What's Changed ##### ✨ Features - feat: add `repo read-file` and `repo read-dir` by [@babakks](https://github.com/babakks) in [#13580](cli/cli#13580) - feat(skills): list available skills when install runs non-interactively by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13548](cli/cli#13548) - Support custom CLAUDE\_CONFIG\_DIR in install by [@tommaso-moro](https://github.com/tommaso-moro) in [#13523](cli/cli#13523) ##### 🐛 Fixes - fix(skills): stage updates in a temp dir and swap in-place by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13449](cli/cli#13449) ##### 📚 Docs & Chores - Make filtering by bot authors more discoverable by [@BagToad](https://github.com/BagToad) in [#13642](cli/cli#13642) - docs(discussion): polish help docs by [@babakks](https://github.com/babakks) in [#13632](cli/cli#13632) - Bump Go in devcontainer by [@spenserblack](https://github.com/spenserblack) in [#13674](cli/cli#13674) #####

Dependencies - chore(deps): bump golang.org/x/text from 0.37.0 to 0.38.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#13640](cli/cli#13640) - chore(deps): bump charm.land/lipgloss/v2 from 2.0.3 to 2.0.4 by [@dependabot](https://github.com/dependabot)\[bot] in [#13663](cli/cli#13663) - chore(deps): bump golang.org/x/term from 0.43.0 to 0.44.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#13661](cli/cli#13661) - chore(deps): bump github/codeql-action from 4.36.1 to 4.36.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#13619](cli/cli#13619) - chore(deps): bump github.com/sigstore/sigstore-go from 1.1.4 to 1.2.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#13662](cli/cli#13662) - chore(deps): bump golang.org/x/crypto from 0.52.0 to 0.53.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#13641](cli/cli#13641) **Full Changelog**: <cli/cli@v2.94.0...v2.95.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

Ran Task 6 against a real public PR (cli/cli#13679): text format with a single backend, JSON format with both backends, and the invalid-PR-number error path all matched the plan's expected output. Full unit test suite (19 tests across 4 files) still green. No code fixes were needed.

s3onghyun requested a review from a team as a code owner June 18, 2026 12:37

s3onghyun requested a review from BagToad June 18, 2026 12:37

github-actions Bot added external pull request originating outside of the CLI core team needs-triage needs to be reviewed unmet-requirements and removed needs-triage needs to be reviewed labels Jun 18, 2026

s3onghyun mentioned this pull request Jun 18, 2026

gh pr checks: blank summary when all checks were cancelled #13680

Closed

babakks added the ready-for-review label Jun 19, 2026

babakks requested changes Jun 19, 2026

View reviewed changes

Cover all printSummary branches in a table test

32db186

Address review: expand TestPrintSummary to exercise every summary path (no checks, all successful, failed, pending, cancelled) and drop the redundant separate regression case. Signed-off-by: Seonghyun Hong <[email protected]>

babakks approved these changes Jun 22, 2026

View reviewed changes

babakks merged commit 23f83e6 into cli:trunk Jun 22, 2026
11 checks passed

babakks mentioned this pull request Jun 22, 2026

Fix cancelled-only PR checks summary #13683

Closed

BrewTestBot mentioned this pull request Jul 2, 2026

gh 2.96.0 Homebrew/homebrew-core#291107

Merged

coderabbitai Bot mentioned this pull request Jul 24, 2026

fix(cli): run on repos with no CI checks and no style file developerz-ai/ai-task-master#293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: show checks summary when all checks were cancelled#13679

fix: show checks summary when all checks were cancelled#13679
babakks merged 2 commits into
cli:trunkfrom
s3onghyun:fix-checks-cancelled-only

s3onghyun commented Jun 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

s3onghyun commented Jun 18, 2026

Uh oh!

babakks left a comment

Uh oh!

babakks Jun 19, 2026

Uh oh!

babakks Jun 19, 2026

Uh oh!

s3onghyun commented Jun 19, 2026

Uh oh!

babakks left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

s3onghyun commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fix

Testing

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

s3onghyun commented Jun 18, 2026

Uh oh!

babakks left a comment

Choose a reason for hiding this comment

Uh oh!

babakks Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

babakks Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

s3onghyun commented Jun 19, 2026

Uh oh!

babakks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

s3onghyun commented Jun 18, 2026 •

edited

Loading