Fix: Honor --remote flag when repository specified via argument#12691
Open
Fix: Honor --remote flag when repository specified via argument#12691
Conversation
Fixes cli#2722 The --remote flag was being ignored when a repository was specified as an argument. This was due to the early return logic combining both inParent and !inParent conditions in a single check. Split the early return into two separate conditions: - For inParent: return early only if neither Remote nor PromptRemote - For !inParent: return early only if none of Clone, PromptClone, Remote, or PromptRemote This ensures the --remote flag is respected in both scenarios.
drtootsie
temporarily deployed
to
cli-automation
GitHub Actions
Inactive
cliAutomation
added
the
external
|
Thank you for your pull request! 🎉 This PR appears to fix the following issues that are not labeled with
help wanted
As outlined in our Contributing Guidelines, we expect that PRs are only created for issues that have been labeled While we appreciate your initiative, please note that:
What happens next:
Thank you for your understanding and contribution to the project! 🙏 This comment was automatically generated by cliAutomation. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2722
Summary
The
--remoteflag was being ignored when a repository was specified as an argument togh repo fork.Changes
Modified the early return logic in
fork.goto properly check the--remoteflag in both scenarios:Testing
All existing tests pass: