Skip to content

Conversation

@vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Oct 4, 2019

this PR implements the interactive PR list we had in the original cli-test repo.

caveats:

  • doesn't visually split out PRs
  • doesn't explain what the contents of the list are
  • doesn't support closing because i need to remember how to do mutations with graphql

it's not ideal but it's something

@vilmibm vilmibm changed the base branch from master to prototype October 4, 2019 03:43
this commit adds `gh pr` back  with the caveat that it doesn't support
closing. i wanted to use graphql to do it but couldn't figure  it out in
time.
@vilmibm vilmibm marked this pull request as ready for review October 4, 2019 15:58
@vilmibm vilmibm merged commit 441a1c9 into prototype Oct 4, 2019
@tierninho tierninho deleted the gh-pr branch October 9, 2019 22:19
@tierninho tierninho restored the gh-pr branch October 9, 2019 22:19
@tierninho tierninho requested review from tierninho and removed request for tierninho October 9, 2019 22:53
@mislav mislav mentioned this pull request Oct 10, 2019
Closed
@mislav mislav deleted the gh-pr branch October 10, 2019 12:35
vilmibm pushed a commit that referenced this pull request Jun 29, 2021
mislav pushed a commit that referenced this pull request Sep 28, 2021
mislav pushed a commit that referenced this pull request Sep 28, 2021
Refactors most of the library to solidify some of the implementation with tests
@pxrth9 pxrth9 mentioned this pull request Nov 19, 2021
20 tasks
saraycp added a commit to saraycp/open-build-service that referenced this pull request Jan 19, 2022
WARNING: this migration is broken, run the test of the migration to
figure out why.

The plan is to add '\b' or similar before and after the regex, in order
to limit the boundaries of a word.  So strings like 'i#1', '[i#1]', '
i#1', etc. match but strings like 'gh#cli/cli#1' don't match with the
regular expression "i#(\d+)".

TODO: we need to confirm that this regex works fine with Perl in the backend.
krauselukas pushed a commit to krauselukas/open-build-service that referenced this pull request Jan 27, 2022
WARNING: this migration is broken, run the test of the migration to
figure out why.

The plan is to add '\b' or similar before and after the regex, in order
to limit the boundaries of a word.  So strings like 'i#1', '[i#1]', '
i#1', etc. match but strings like 'gh#cli/cli#1' don't match with the
regular expression "i#(\d+)".

TODO: we need to confirm that this regex works fine with Perl in the backend.
dmgardiner25 added a commit that referenced this pull request Oct 11, 2022
Fixes races and timeout issue
andyfeller pushed a commit that referenced this pull request Apr 9, 2024
jtmcg pushed a commit that referenced this pull request Jan 6, 2025
Fixed test for stdout in non-tty use case of repo fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants