Repository navigation
make install fails in v2.28.0 due to non portable option to 'install' being used #7368
Description
Describe the bug
make install in v2.28.0 results in the following on my system:
% make DESTDIR=/tmp/dst.gh install
build.go: `bin/gh` is up to date.
go run ./cmd/gen-docs --man-page --doc-path ./share/man/man1/
mkdir -p ./share/bash-completion/completions ./share/fish/vendor_completions.d ./share/zsh/site-functions
bin/gh completion -s bash > ./share/bash-completion/completions/gh
bin/gh completion -s fish > ./share/fish/vendor_completions.d/gh.fish
bin/gh completion -s zsh > ./share/zsh/site-functions/_gh
install -d /tmp/dst.gh/usr/local/bin
install -m755 bin/gh /tmp/dst.gh/usr/local/bin/
install -d /tmp/dst.gh/usr/local/share/man/man1
install -m644 ./share/man/man1/* /tmp/dst.gh/usr/local/share/man/man1/
install -DT -m644 ./share/bash-completion/completions/gh /tmp/dst.gh/usr/local/share/bash-completion/completions/gh
install: illegal option -- D
Expected vs actual behavior
I expected the install to complete without error.
Regression
Issue is not present in v2.27.0.
Activity
debohman commentedon Apr 25, 2023
It appears there is not a -T option, either.
mislav commentedon Apr 25, 2023
Thank you for reporting. Which OS version do you experience this on?
@vilmibm Would you be able to look into this? After merging in #7324, you should be able to cut new releases from
trunk./cc @Xerkus #7293
Xerkus commentedon Apr 25, 2023
I was wondering why folders were created as separate install command, figured it was because installed files were not a single file destination.
macOS I presume?
debohman commentedon Apr 25, 2023
Yes, macOS.