Skip to content

Commit 0cf1092

Browse files
Merge pull request #14462 from cli/revert-14437-williammartin-apple-codesign-action
Revert "Use internal Apple codesign action"
2 parents 9eb4db2 + 189706b commit 0cf1092

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎.github/workflows/deployment.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ jobs:
127127
128128
- name: Add App Store Connect API key to keychain
129129
if: inputs.environment == 'production'
130-
uses: github/setup-apple-codesign@9ba41e90aff70dea04ae487b776f98ee5efd610f
130+
uses: nodeselector/setup-apple-codesign@309922bbe4c7277c477635e68d3a1af52d8ad06b
131131
id: setup-apple-codesign
132132
with:
133133
asset-type: "app-store-connect-api-key"

‎docs/release-process-deep-dive.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ There is no signing of linux artifacts in this job. See the [release job](#relea
147147
rm $RUNNER_TEMP/cert.p12
148148
- name: Add App Store Connect API key to keychain
149149
if: inputs.environment == 'production'
150-
uses: github/setup-apple-codesign@9ba41e90aff70dea04ae487b776f98ee5efd610f
150+
uses: nodeselector/setup-apple-codesign@ab275d0f6fb63ef9e20b12b42ea0d567f935723c
151151
id: setup-apple-codesign
152152
with:
153153
asset-type: "app-store-connect-api-key"
@@ -235,7 +235,7 @@ Signing of MacOS artifacts uses `codesign` and notarization uses `xcrun notaryto
235235
Signing and notarization are set up across three steps that run only when `inputs.environment == 'production'`:
236236

237237
1. **Install code signing certificate** creates a dedicated keychain and imports the Developer ID Application certificate used by `codesign`.
238-
2. **Add App Store Connect API key to keychain** uses the internal `github/setup-apple-codesign` action to materialise the App Store Connect API key (`.p8`) that `notarytool` authenticates with, exposing its key path, key id and issuer id as step outputs.
238+
2. **Add App Store Connect API key to keychain** uses the [`nodeselector/setup-apple-codesign`](https://github.com/nodeselector/setup-apple-codesign) action to materialise the App Store Connect API key (`.p8`) that `notarytool` authenticates with, exposing its key path, key id and issuer id as step outputs.
239239
3. **Configure notarization credentials** runs `xcrun notarytool store-credentials` to persist those API key details into the keychain under the profile name `notarytool-password`, so later `notarytool submit` calls can reference the profile instead of passing credentials directly.
240240

241241
In order to perform signing, a keychain must be configured with the signing certificate. Comments have been added to provide clarity to the script:

0 commit comments

Comments
 (0)