v1.5.0 by JoryHogeveen · Pull Request #22 · cleverness/widget-css-classes

JoryHogeveen · 2017-06-19T23:03:33Z

Ready for testing!

This PR will address version 1.5.0, fixing mutiple issues:

Changelog

Feature: Option to try and fix the widget parameters if they are invalid: Option to fix invalid registered sidebars #24
Feature: Option to remove duplicate classes: Option to remove duplicates #25
- This method also enhances the speed of how classes are added!
  - In a loop of 500 times the new method is approx 3 times faster.
    In a loop of 50000 times over 30 times!
Enhancement: Sort classes based on the predefined classes on the frontend by default. Sort classes in frontend #19
Enhancement: Classes filter for frontend (for sorting or modifications): Sort classes in frontend #19
- widget_css_classes modify all classes added by this plugin.
- widget_css_classes_custom modify custom input classes.
Enhancement: Plugin settings filter (widget_css_classes_set_settings), overwrites user settings: Add hook for predefined classes based on the current theme #16
Enhancement: Plugin default settings filter (widget_css_classes_default_settings): Feature Request #4
Enhancement: Capability filters for form fields: Enhancement: Add filters to change capability access per form input type #21
- widget_css_classes_id_input_capability ID input
- widget_css_classes_class_input_capability classes input
- widget_css_classes_class_select_capability predefined classes select (also hides classes input if invalid)
Compatibility: WP External Links: Compatibility: WP External Links #17, thanks to Victor @freelancephp
Fix: Form wrapper div style: Fix widget form div CSS: clear both #18, thanks to Chuck Reynolds @ryno267
Fix: Enable sortable input selection (IE-11 fix): IE11 issue with predefined classes admin #20
UI: Enhance setting page JavaScript and remove relCopy library dependency.
i18n: Remove Dutch and Russian languages from plugin distribution (available on translate.wordpress.org). Copy translations to wp.org and remove files from plugin #23
CodeClimate fixes (related PR: Add integration and validation tools: TravisCI + CodeClimate & Some refactor fixes #15)

Core changes:

Refactoring for CC fixes
Added setting handlers in the library to make sure settings are always of the correct type and format
- Also added a unit test for this.
Simplified code where possible
Improved inline PHPdocs

Tests:

Settingpage & Widget form

Check saving and displaying options.
Try to save wrong stuff by manually edit the form content in the console.
- Add some malicious stuff in there.

Widget form

Test capability filters
- Existing settings should save even if the input isn't shown
- Disallowing predefined select should also hide the custom CSS input

Frontend

Check correct rendering of all set classes (custom, predefined and other)
Check order of predefined classes
Check params fix option (register sidebar with empty before and after parameters to test)
Check appending classes with double and single quote format attributes.
Removing duplicates

ImportExport

Updating

Configure plugin in an older version and update to the new version. All settings should stay the same and the front-end should work without changes (excerpt for class order)
- 1.1
- 1.2
- 1.4

…instance. See cleverness#19

…handling. See cleverness#21

See cleverness#18

…set filters Related: cleverness#16 New filter: `widget_css_classes_set_settings`

JoryHogeveen · 2017-06-20T05:04:08Z

@cleverness
Let me know if you see anything you don't like or you would like to change.

Also, with the patches for the mentioned issues (new hooks for example) it might be good to set the version to 1.5.0. Let me know what you think.

See cleverness#17

JoryHogeveen · 2017-06-21T14:51:53Z

includes/widget-css-classes.class.php


-		// Add first, last, even, and odd classes
-		if ( 1 === (int) $widget_css_classes['show_number'] || 1 === (int) $widget_css_classes['show_location'] || 1 === (int) $widget_css_classes['show_evenodd'] ) {
 			if ( ! $widget_number ) {


@cleverness
At the start of this method $widget_number is declared as a global variable. Is there a specific reason to make it a global variable? It doesn't look like it's supposed to be modified externally so maybe it's better to declare it as a static variable inside this method.
Let me know!

I don't think there is a reason it needs to global, but again, that was in the initial build in 2012 I did so the details on why are pretty fuzzy.

cleverness · 2017-06-22T01:48:52Z

I did some quick basic testing from just the previous version to this. I didn't run into any issues.

JoryHogeveen · 2017-06-22T05:12:41Z

Alrighty, I'll make some time today or this weekend to test some more and if that's all good that I think it's good to go!

Also enhanced the code. Use more native array functions instead of foreach loops.

…e + phpDoc

…ions.

See cleverness#25

…ff not working (class constant).

…nique replacement

JoryHogeveen · 2017-06-22T11:14:27Z

@cleverness
If/when you have the time, can you test again? Also frontend display etc?
I've added another new option "remove duplicate classes" and enhanced the code a bit more.
All tests in the tasklist are done and checked in two of my test sites but an extra pair of eyes is always good!

I'm going to wrap it up for this release, other stuff will need to go in a next one. If you can think of anything I should check/fix/change for 1.5 let me know!

JoryHogeveen added 6 commits June 20, 2017 00:48

Merge remote-tracking branch 'refs/remotes/cleverness/master'

bc19c56

Default ID value

7d3ff29

JSdoc block

6efa082

Add widget_css_classes filter to change the CSS classes per widget …

25767b2

…instance. See cleverness#19

Separate form handling in mutiple smaller functions + add capability …

1c0d6b2

…handling. See cleverness#21

PHPdoc + whitespaces

af7404c

JoryHogeveen added enhancement feature labels Jun 19, 2017

JoryHogeveen added this to the 1.4.1 milestone Jun 19, 2017

JoryHogeveen self-assigned this Jun 19, 2017

JoryHogeveen requested a review from cleverness June 19, 2017 23:03

JoryHogeveen added 13 commits June 20, 2017 01:28

Merge remote-tracking branch 'refs/remotes/cleverness/master'

7dc9be2

Some CC fixes

51ac54b

Always set string type by default

6cc61a9

Filter predefined classed before parsing

19e00f5

Merge remote-tracking branch 'refs/remotes/cleverness/master'

781a2aa

clear both on form wrapper div + phpdoc

56d710d

See cleverness#18

Wrap settings with labels for a11y

1af23c4

Basename used in library, make sure it exists

94b23f2

Set correct versions for assets

b9fc6bc

Not needed, already done in activation function

c5eab92

Enhance method names

e685cbb

Add settings handlers & move settings to lib + add settings load and …

e9b6df3

…set filters Related: cleverness#16 New filter: `widget_css_classes_set_settings`

Merge remote-tracking branch 'refs/remotes/cleverness/master'

8e83bae

JoryHogeveen added 5 commits June 20, 2017 07:19

Add WP External Links fix

86d9c85

See cleverness#17

Merge yes/no option functions

172d1a5

Current tab handling + CC fixes

bc41747

Merge remote-tracking branch 'refs/remotes/cleverness/master'

8c3e19d

esc_attr for option key instead of string casting

1225f10

JoryHogeveen commented Jun 21, 2017

View reviewed changes

JoryHogeveen added 2 commits June 22, 2017 07:02

Remove tab and eol characters

bd578c9

Change widget counter name and make it a local variable

6bf3fd7

JoryHogeveen added 18 commits June 22, 2017 08:01

Add init function to set capabilities. Only run the filters once.

009c532

Secure widget update handling with capability verification

67800d9

Also enhanced the code. Use more native array functions instead of foreach loops.

Enhance update method. Let it run faster if the user has full access.

7438935

Remove empty check

4e90cac

switch to a switch (hehe) + another \t\n found

eb2f1cc

Change opacity if predefined classes is disabled.

6206b9c

Add type input classes

b58ce37

Remove relCopy dependency + update changelog

525f1b4

Make setting class properties protected for possible class inheritanc…

f17cd52

…e + phpDoc

Enhance update script. Now tested and validated for all previous vers…

277954d

…ions.

Add description handler + make general form methods public

037eef8

Set plugin domain as a class constant

0edf77a

Option to remove duplicate classes.

9763808

See cleverness#25

Add append_to_attribute() tests + fix setting tests

46f2337

See cleverness#25

Disable: The $domain arg must be a single string literal, not "". Sni…

f32cbf5

…ff not working (class constant).

No valid esc function for HTML (kses is not encouraged)

537f953

Enable filter_unique setting on append_to_attribute + enhance non-u…

cc7e403

…nique replacement

End if().

00baade

JoryHogeveen added 5 commits June 22, 2017 15:55

Update notice and plugin deactivation instead of fatal error.

8d48b97

Simplify code, prevent unnecessary indentation

33f100a

1.5.0

5e60b66

Simplify importexport method (one less tab)

9c7c315

Ignore importexport complexity warning for now

60b3570

JoryHogeveen merged commit 0ccf09e into cleverness:master Jun 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1.5.0#22

v1.5.0#22
JoryHogeveen merged 84 commits intocleverness:masterfrom
JoryHogeveen:master

JoryHogeveen commented Jun 19, 2017 •

edited

Loading

Uh oh!

JoryHogeveen commented Jun 20, 2017

Uh oh!

JoryHogeveen Jun 21, 2017

Uh oh!

cleverness Jun 22, 2017

Uh oh!

JoryHogeveen Jun 22, 2017

Uh oh!

cleverness commented Jun 22, 2017

Uh oh!

JoryHogeveen commented Jun 22, 2017

Uh oh!

JoryHogeveen commented Jun 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

JoryHogeveen commented Jun 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Core changes:

Tests:

Uh oh!

JoryHogeveen commented Jun 20, 2017

Uh oh!

JoryHogeveen Jun 21, 2017

Choose a reason for hiding this comment

Uh oh!

cleverness Jun 22, 2017

Choose a reason for hiding this comment

Uh oh!

JoryHogeveen Jun 22, 2017

Choose a reason for hiding this comment

Uh oh!

cleverness commented Jun 22, 2017

Uh oh!

JoryHogeveen commented Jun 22, 2017

Uh oh!

JoryHogeveen commented Jun 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JoryHogeveen commented Jun 19, 2017 •

edited

Loading