Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with one setting in dFactory Repsonsive Lightbox plugin #33

Closed
woolfa opened this issue Dec 31, 2017 · 6 comments
Closed

Conflict with one setting in dFactory Repsonsive Lightbox plugin #33

woolfa opened this issue Dec 31, 2017 · 6 comments
Assignees
@JoryHogeveen
Labels
compatibility
Milestone
1.5.3

Comments

@woolfa
Copy link

woolfa commented Dec 31, 2017

Expected Behavior

Custom classes can be added to widgets.

Actual Behavior

Custom classes (text or predefined) do not get written out to html, but are displayed in Widget UI. Even custom widget css classes built into theme no longer work. The standard ones do get written out to html successfully (widget-first, widget-last, etc)

Steps to Reproduce the Problem

  1. Install dFactory Responsive Lightbox plugin v 1.7.2 ( https://wordpress.org/plugins/responsive-lightbox/ )
  2. Goto Plugin Settings, and General Settings tab
  3. Select either "PrettyPhoto" or "Featherlight" as Default Lightbox (only tested with these two and the paid "Lightcase" that I purchased)
  4. Check the box (enable) for "Widgets : Enable lightbox for widgets content."
  5. Click Save at bottom.
  6. Clear browser cache, and reload site to see issue.
  7. Tried deactivating and deleting Widget CSS Classes and reinstalling, but issue persisted.
  8. Disabled Repsonsive Lightbox setting for widget contents to resolve.

Notes

  • I use a page caching plugin, but cleared cache for all test steps.

Specifications

plugin-list
@JoryHogeveen
Copy link
Collaborator

Hi @woolfa
Thank you for reporting!
I'm guessing that that plugin hooks into the same area as this one when enabled for widgets. I'll check the code asap to see if I can come up with a neat compatibility fix.

@JoryHogeveen JoryHogeveen self-assigned this Jan 2, 2018
@JoryHogeveen JoryHogeveen added this to the 1.5.3 milestone Jan 2, 2018
@JoryHogeveen
Copy link
Collaborator

Error found and possibly fixed, but.. do you know the actual purpose of that setting? If I disable the widget setting the widget fancyboxes still work..

@JoryHogeveen JoryHogeveen mentioned this issue Jan 2, 2018
Merged
@JoryHogeveen
Copy link
Collaborator

Got it, it's for the WYSIWYG widgets as far as I can see. Got a patch pushed to the dev branch.
If you would like to test it as well that would be great!
Please check the referenced pull request v1.5.3 (#34).

@woolfa
Copy link
Author

woolfa commented Jan 2, 2018

Tested v1.5.3 and that works perfectly now. Thank you for quick response!

@woolfa
Copy link
Author

woolfa commented Jan 2, 2018

...and, not sure what the setting exactly does in Responsive Lightbox plug-in. Not familiar enough with it yet.

@JoryHogeveen
Copy link
Collaborator

@woolfa
Ok perfect, thanks!
I found that this impacts auto-lightbox handling for text/wysiwyg widgets. Maybe also other widgets, not sure.
I'll try to make an official update a.s.a.p.!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoryHogeveen JoryHogeveen

Labels
compatibility
Projects
None yet
Milestone
1.5.3
Development

No branches or pull requests
2 participants
@JoryHogeveen @woolfa