Skip to content

fix(clerk-js): Remove setActive() call from signOut() - #5171

Merged
brkalow merged 28 commits into
mainfrom
brk.feat/sign-out-no-set-active
Feb 28, 2025
Merged

fix(clerk-js): Remove setActive() call from signOut()#5171
brkalow merged 28 commits into
mainfrom
brk.feat/sign-out-no-set-active

Conversation

@brkalow

@brkalow brkalow commented Feb 14, 2025

Copy link
Copy Markdown
Member

Description

Removes setActive() call from signOut() implementation, fixing a number of bugs related to sign out.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5a0ecb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/clerk-js Patch
@clerk/nextjs Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 0:29am

@brkalow
brkalow requested a review from a team February 18, 2025 23:31
@brkalow
brkalow marked this pull request as ready for review February 18, 2025 23:31
@panteliselef

panteliselef commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

!snapshot

1 similar comment
@panteliselef

panteliselef commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

!snapshot

@panteliselef

panteliselef commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

clerk-cookie commented Feb 28, 2025

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.12-snapshot.v20250228120517
@clerk/clerk-js 5.54.1-snapshot.v20250228120517
@clerk/dev-cli 0.0.11-snapshot.v20250228120517
@clerk/clerk-expo 2.8.1-snapshot.v20250228120517

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/dev-cli

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@panteliselef

panteliselef commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

clerk-cookie commented Feb 28, 2025

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.13-snapshot.v20250228122946
@clerk/clerk-js 5.54.2-snapshot.v20250228122946
@clerk/clerk-expo 2.8.2-snapshot.v20250228122946
@clerk/nextjs 6.12.2-snapshot.v20250228122946

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

brkalow
brkalow commented Feb 28, 2025
View reviewed changes
Comment thread .changeset/silver-masks-knock.md Resolved
brkalow
brkalow commented Feb 28, 2025
View reviewed changes
Comment thread .changeset/dry-tigers-mate.md Resolved
@brkalow
brkalow requested a review from a team February 28, 2025 16:11
panteliselef
panteliselef approved these changes Feb 28, 2025
View reviewed changes

@panteliselef panteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢

@brkalow
brkalow merged commit 6f20f76 into main Feb 28, 2025
@brkalow
brkalow deleted the brk.feat/sign-out-no-set-active branch February 28, 2025 18:57
@clerk-cookie clerk-cookie mentioned this pull request Feb 28, 2025
Merged
@panteliselef panteliselef mentioned this pull request Mar 4, 2025
Closed
9 tasks
jacekradko pushed a commit that referenced this pull request Mar 5, 2025
@brkalow @panteliselef Jacek
fix(clerk-js): Remove setActive() call from signOut() (#5171)
bcf71f4 
Co-authored-by: panteliselef <[email protected]>
@coderabbitai coderabbitai Bot mentioned this pull request Apr 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmilewski tmilewski tmilewski approved these changes
@dstaley dstaley dstaley approved these changes
+1 more reviewer
@panteliselef panteliselef panteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clerk-js integration nextjs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brkalow @panteliselef @clerk-cookie @tmilewski @dstaley