Skip to content

Commit 84b96aa

Browse files
clementperonclaude
andcommitted
pythongh-156780: Emscripten: drop the promising_main test
The main() wrapper is unchanged from main, so there is nothing new to cover. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 09b9faf commit 84b96aa

3 files changed

Lines changed: 2 additions & 45 deletions

File tree

‎Makefile.pre.in‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1133,13 +1133,7 @@ web_embed_test/main.js: $(WEB_EMBED_TEST_DIR)/main.c $(LIBRARY) $(ZIP_STDLIB)
11331133
--preload-file $(ZIP_STDLIB)@/lib/stdlib.zip
11341134

11351135
.PHONY: web_embed_test
1136-
web_embed_test: web_embed_test/main.js web_embed_test/promising_main.js
1137-
1138-
web_embed_test/promising_main.js: $(WEB_EMBED_TEST_DIR)/promising_main.c Programs/emscripten_beforemain.o Python/emscripten_syscalls.o
1139-
@mkdir -p web_embed_test
1140-
$(LINKCC) $(PY_STDMODULE_CFLAGS) $(PY_CORE_EXE_LDFLAGS) -O2 -g0 -o $@ \
1141-
$(WEB_EMBED_TEST_DIR)/promising_main.c \
1142-
Programs/emscripten_beforemain.o Python/emscripten_syscalls.o
1136+
web_embed_test: web_embed_test/main.js
11431137

11441138
.PHONY: web_example
11451139
web_example: web_example/python.mjs web_example/python.worker.mjs web_example/index.html web_example/server.py web_example/$(ZIP_STDLIB)

‎Platforms/emscripten/web_embed_test/promising_main.c‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎Platforms/emscripten/web_embed_test/run_test.sh‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,4 @@ cd "$BUILD_DIR/web_embed_test"
1818
rc=0
1919
out=$("$NODE" $NODE_FLAGS main.js 2>&1) || rc=$?
2020
echo "$out"
21-
[ "$rc" -eq 0 ]
22-
grep -q "web_embed_test: ok" <<<"$out"
23-
24-
if [ "$("$NODE" $NODE_FLAGS -p 'typeof WebAssembly.promising')" = function ]; then
25-
rc=0
26-
out=$("$NODE" $NODE_FLAGS promising_main.js 2>&1) || rc=$?
27-
echo "$out"
28-
[ "$rc" -eq 7 ]
29-
grep -q "web_embed_test: main resumed" <<<"$out"
30-
fi
21+
[ "$rc" -eq 0 ] && grep -q "web_embed_test: ok" <<<"$out"

0 commit comments

Comments
 (0)