Merged
Conversation
Fixes #22494 **Bug** References without a definition can cause the markdown table of contents provider to break **Fix** Pass in an empty environment to markdown-it `parse` to prevent the null dereference on invalid links.
Add Command for navigating around visible editors/viewlets/repl
- Reuse define keybindings widget
…: [, if yes enter a newline fixes #22624
- Use List widget to render keybindings
- Open default keybindings while opening keybindings file like before
…hrough themingRegistry
- Define keybinding action with keyboard shortcut - Search keybindings action with keyboard shortcut
- Register keybinding for remove action - Make other actions as just keybinding actions
Add backwards search to preferences view
- Down arrow to navigate from search to list
- Do not navigate by Enter from search box
#22421) * Prototype Allowing Extensions to Extend the Builtin Markdown Extension **Problem** There have been requests for adding new functionality to the markdown extension preview, such as supporting rendering of math or other syntax in the preview. The only current solution to this is create an extension that provides its own markdown preview. This results in inconsitent behavior with our markdown preview and is not a very scalable approach. We would like to find a way to allow users to add these extensions to our markdown preview without bundling the extensions in the preview itself. **Fix** Prototypes a new contribution point that extensions can use to extend the vscode markdown extension. Three types of extensions are possible: adding stypes to the preview, adding scripts to the preview, and extending the markdown it renderer. My current approach defines the contributed markdown extensions in the package.json using a structure like this: ``` "contributesTo": { "vscode.markdown": { "plugins": [ "./out/math" ], "scripts": [], "styles": [ "./media/math.css" ] } } ``` We could change the structure here. This design uses a pull model where markdown extensions are looked up by the vscode.markdown extension itself. The other approach for extension registration would be to use a push model. This would have the vscode.markdown extension export an api that each markdown extension would invoke to register new scripts/styles/plugins. I may switch over to this model but was interested in seeing what a more declarative approach would look like. Let me know if you have any thoughts one way or the other. The downside of allowing extensions like this is that they can completely change how the markdown preview looks and works. There is no well defined API for restricting what extensions can do like we have with VScode. * Use extensionDependencies * Remove example extension * Added gating and activation event
cleidigh
pushed a commit
that referenced
this pull request
Aug 5, 2017
cleidigh
pushed a commit
that referenced
this pull request
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.