Repository navigation
Allow overriding secretKey for kubeadm kubeconfig - #408
Merged
Merged
Conversation
✅ Deploy Preview for kamaji-documentation canceled.
|
kvaps
marked this pull request as ready for review
February 5, 2024 12:43
kvaps
force-pushed
the
kubeconfig-secret-key
branch
from
February 5, 2024 12:49
83ea282 to
dc7f6ee
Compare
kvaps
force-pushed
the
kubeconfig-secret-key
branch
from
February 5, 2024 12:51
dc7f6ee to
765d7fd
Compare
prometherion
requested changes
Feb 26, 2024
kvaps
force-pushed
the
kubeconfig-secret-key
branch
2 times, most recently
from
March 5, 2024 08:39
6df5b94 to
5324710
Compare
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named `<cluster>-admin-kubeconfig` into a `cluster-info` configmap of tenant cluster, which then used by kubeadm to join nodes. This change introduces a new annotation, `kamaji.clastix.io/kubeconfig-secret-key`, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf). Example: ``` kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc ``` This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by clastix#403). Signed-off-by: Andrei Kvapil <[email protected]>
kvaps
force-pushed
the
kubeconfig-secret-key
branch
from
March 5, 2024 08:40
5324710 to
294d70a
Compare
prometherion
approved these changes
Apr 3, 2024
prometherion
left a comment
prometherion
left a comment
Member
There was a problem hiding this comment.
LGTM, this will be available in the upcoming Kamaji release (planned for v0.5.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up clastix/cluster-api-control-plane-provider-kamaji#78
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named
<cluster>-admin-kubeconfiginto acluster-infoconfigmap of tenant cluster, which then used by kubeadm to join nodes.This change introduces a new annotation,
kamaji.clastix.io/kubeconfig-secret-key, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf).Example:
This will instruct the system to use
super-admin.svca kubeconfig with a local service FQDN (introduced by #403).