Skip to content

Update go libs - #93

Merged
prometherion merged 1 commit into
clastix:masterfrom
aenix-io:update-go-libs
Apr 22, 2024
Merged

prometherion merged 1 commit into
clastix:masterfrom
aenix-io:update-go-libs

Conversation

@kvaps

@kvaps kvaps commented Apr 22, 2024 •

Copy link
Copy Markdown
Contributor

required for #78

go 1.20 --> 1.22
kamaji v0.4.0 --> v0.5.0
cluster-api v1.4.0-beta.2.0 --> v1.6.4
kubernetes v0.29.0 --> v0.30.0
controller-gen v0.12.0 --> v0.14.0

@prometherion

Copy link
Copy Markdown
Member

I think we need to update also the Go version of the underlying GH actions.

@kvaps
kvaps force-pushed the update-go-libs branch 2 times, most recently from 4b7f024 to 848c758 Compare April 22, 2024 09:57
Comment thread .github/workflows/ci.yaml Resolved
@prometherion

Copy link
Copy Markdown
Member

I know the problem with controller-gen and Go 1.22, we just need to bump it to v0.14.0

@kvaps
kvaps requested a review from prometherion April 22, 2024 10:15
@prometherion

Copy link
Copy Markdown
Member

This change is a bit intrusive 😄

Please, let's generate manifests with make release and let's remove the gocognit ignore, you can double check with make lint.

@kvaps

kvaps commented Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

Sure fixed

@kvaps
kvaps force-pushed the update-go-libs branch 2 times, most recently from 3693f32 to 48bafab Compare April 22, 2024 15:55
@kvaps

kvaps commented Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

I had old controller-gen at my PC, now diff should be fixed

@prometherion

Copy link
Copy Markdown
Member

make release is still required, I guess

go 1.20 --> 1.22
kamaji v0.4.0 --> v0.5.0
cluster-api v1.4.0-beta.2.0 --> v1.6.4
kubernetes v0.29.0 --> v0.30.0
controller-gen v0.12.0 --> v0.14.0

Signed-off-by: Andrei Kvapil <[email protected]>
@kvaps

kvaps commented Apr 22, 2024 •

Copy link
Copy Markdown
Contributor Author

aha, you're right. rebased

@prometherion
prometherion merged commit e949f41 into clastix:master Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants