Merged
Conversation
Member
Author
|
Fixed it up so package names print right now, so I think it fixes #1596. |
Also start on making package functions accept Lisp strings instead of std::strings. Using std::strings means no support for extended strings, which is pretty dumb.
not every place, though. still working on it. but this is another step towards not assuming package names are base strings. and, bonus? Less stupid consing.
This fixes the FASO build.
I'm leaving in the string one since we probably use it during boot or for extensions or some crapola like that.
__repr__ is still broken but it's kind of dumb anyway. To fix it we'd have to make it not return a std::string, I guess, which would be a pretty severe change.
Previously it tested if the name was "", but that doesn't work well given character strings, or the pathological case of an empty name. We already have a "deleted" flag so we may as well use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans some stuff up and, importantly, allows package names that aren't just base strings (#1596).
Unfortunately does not fix the way package objects are printed - which is relatively minor, but annoying. The problem is it goes through repr and that returns a std::string.