Skip to content

chore(i18n): add Azerbaijani (az) translations - #7906

Merged
Dragon1573 merged 1 commit into
clash-verge-rev:devfrom
jamalkamaladdin:feat/az-locale
Sep 20, 2026
Merged

Dragon1573 merged 1 commit into
clash-verge-rev:devfrom
jamalkamaladdin:feat/az-locale

Conversation

@jamalkamaladdin

Copy link
Copy Markdown
Contributor

Problem

Fixes #7905

Clash Verge Rev ships thirteen interface languages (ar, de, en, es, fa, id, jp, ko, ru, tr, tt, zh, zhtw) and Azerbaijani is not one of them. resolveLanguage in src/services/i18n.ts and resolve_supported_language in the clash-verge-i18n crate both fall back to zh, so a user with an az system locale gets Simplified Chinese in the window and in the tray menu.

Approach

Both locale layers are discovered at runtime, so a new language needs the two bundles plus the two registration points that are not discovered automatically. The frontend loads src/locales/<lang>/*.json through import.meta.glob, and the backend crate reads crates/clash-verge-i18n/locales/<lang>.yml through rust_i18n::available_locales!(). What is not automatic is supportedLanguages, which gates resolveLanguage, and the label map in the settings dropdown, which falls back to the raw language code when a code is missing. These are the steps listed under "Adding a new language" in docs/CONTRIBUTING_i18n.md.

Scope

New directory src/locales/az/ with the ten namespaces that src/locales/en/ defines: connections, home, layout, logs, profiles, proxies, rules, settings, shared, tests. 926 strings, all filled in, key names and key order taken from en.

New file crates/clash-verge-i18n/locales/az.yml: 74 strings for the tray menu, notifications and service dialogs.

src/services/i18n.ts: az appended to supportedLanguages.

src/components/setting/setting-verge-basic.tsx: az added to the language label map as Azərbaycan dili.

Nothing else changed. pnpm i18n:format and pnpm i18n:types leave the tree unchanged after this commit, since the generated typings are derived from src/locales/en/ alone.

Assisted by: OpenAI Codex (translation drafting and review pass) and Claude Opus (repository changes)

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Verdict: needs-fix
  • Issue linkage: present, but weak substance
  • Ownership evidence: mixed
  • Confidence: medium

Signals

  • Issue #7905 was opened by the same account that opened this PR only ~4 minutes before the PR itself, contains no reproduction detail beyond the template checkboxes, and its problem description is essentially a paraphrase of this PR's own "Problem" section. There is no maintainer triage, label, or third-party engagement on the issue — it satisfies the form of issue linkage but not its independent substance.
  • On the positive side, the diff scope is tight and matches the stated problem precisely: new src/locales/az/ bundle, a new crates/clash-verge-i18n/locales/az.yml, and the two required registration points (supportedLanguages in src/services/i18n.ts, and the label map in setting-verge-basic.tsx) — no unrelated files are touched.
  • The PR body references repo-specific process (docs/CONTRIBUTING_i18n.md, the behavior of pnpm i18n:format/pnpm i18n:types against the en bundle) rather than generic boilerplate, which is a modest counter-signal of investigation into repo conventions.
  • The PR is a single commit with no review discussion yet (0 comments), so there is no visible iteration or reviewer-driven adjustment to weigh either way at this point.

Requested Follow-up

Clearer issue linkage would help: since the issue was authored by the same person immediately before opening the PR with no independent triage, it would strengthen ownership evidence to have the issue reflect genuine prior discussion or reports from other users hitting this locale gap, or for the PR author to explain in-thread why this was raised as a personal request rather than a reported bug.

Label Outcome

ai-slop:med

Generated by PR AI Slop Review for #7906 · copilot · auto · 27.6 AIC · ⌖ 6.31 AIC · ⊞ 11.7K · ◷

@jamalkamaladdin

Copy link
Copy Markdown
Contributor Author

No earlier report existed. contributing asks for a linked issue, so #7905 was opened before the pull request.
Diff: src/locales/az, crates/clash-verge-i18n/locales/az.yml, supportedLanguages in src/services/i18n.ts, label map in setting-verge-basic.tsx. Close #7905 if you want the locale judged without the link.

@Dragon1573

Copy link
Copy Markdown
Collaborator

Important

There're 2 concerns of maintainers:

  1. None of us know about Azerbaijani.
  2. We decide not to merge this in the next release. May will be merged till v2.6.0 or such.

If you're using Windows amd64, you can try "daily version" in my fork. Note that only GVisor in TUN mode is currently available. We're tracking this bug.

@Dragon1573 Dragon1573 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ After manual validation, I can't find prominent bugs of Azerbaijani translations. Pull request is acceptable to be merged.

@Dragon1573
Dragon1573 added this pull request to the merge queue Sep 20, 2026
Merged via the queue into clash-verge-rev:dev with commit 3c24d9c Sep 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[I18N] New language request: Azerbaijani (az)

2 participants