Prefer cabal conditionals over CPP heavy code. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi! Sorry for the lack of response on this. I recently became a father, so I've been somewhat "distracted" lately :-) I hope to have a proper look at this before the end of the year. |
Collaborator
Author
|
Congrats Christiaan. |
added 2 commits
January 13, 2022 14:35
Update CI to use GHC 9.0.2 / 9.2.1
Collaborator
Author
|
I've modified my site's hakyll setup so that I can have unlisted path for blog posts up for review and moved the one about conditional coding there. |
Collaborator
Author
|
I put off doing the rebase until today as I was half awake yesterday from too much nordic ski and through sleepy eyes rewriting history felt too daunting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't normally make pull requests like this so I wrote a blog post on why I prefer cabal conditionals over CPP heavy code.
I practised these techniques on
ghc-tcplugins-extrabefore using them with success elsewhere.