Merged
Conversation
Contributor
Author
|
@wardi - this PR may fix the 2 issues ckan-docker-base #192 and ckan-docker #93 however I'm scratching my head as to what exactly is going on as the 2 issues are using the alpine images and although they did significantly change with simplify repo change the build instructions in the Dockerfile did not change...much |
avdata99
approved these changes
Nov 28, 2024
Member
avdata99
left a comment
avdata99
left a comment
There was a problem hiding this comment.
I assume only ONBUILD commands requires the -p param and we can skip the others
duttonw
approved these changes
Nov 29, 2024
Contributor
duttonw
left a comment
duttonw
left a comment
There was a problem hiding this comment.
It does not hurt to have the -p on all mkdir, so that it also handles parents being created if missed prior (as well as if already existing)
Contributor
Author
|
Yes, I think getting rid of all |
Member
|
This looks good, @kowh-ai can you:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be good practice especially if using the
ONBUILDDocker command