Conversation
They use a reusable workflow that: 1. Sets things up 2. Builds the base image 3. Tests the base image. Right now it just runs `ckan --help` but it's a good indicator that everything works 4. Builds the dev image 5. Runs some logic tests that should cover most of CKAN functionality These don't test actual endopoints of the running container as it made things more complicated but we can explore it in the future. To be able to run the built images locally we need the service containers (solr, pg, etc) and to make these available to the running container (inside the Github running container) we are exposing the necessary ports and (ab)using the `--net=host` option.
And upgrade pytest-rerunfailures
To avoid error:
File "/usr/lib/python3.9/site-packages/setuptools/_vendor/typeguard/_pytest_plugin.py", line 53, in pytest_addoption
add_ini_option("string")
File "/usr/lib/python3.9/site-packages/setuptools/_vendor/typeguard/_pytest_plugin.py", line 22, in add_ini_option
parser.addini(
File "/usr/lib/python3.9/site-packages/_pytest/config/argparsing.py", line 131, in addini
assert type in (None, "pathlist", "args", "linelist", "bool")
AssertionError
Contributor
|
This is all good stuff @amercader - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes #85, which should be merged first
The build and test actions use a reusable workflow that:
ckan --helpbut it's a good indicator that everything worksThese don't test actual endopoints of the running container as it made things more complicated but we can explore it in the future.
To be able to run the built images locally we need the service containers (solr, pg, etc) and to make these available to the running
container (inside the Github running container) we are exposing the necessary ports and (ab)using the
--net=hostoption.It also fixes errors in the images that were surfaced by actually having tests 😎