Update build.sh to tag CKAN 2.10 and 2.9 images correctly#117
Merged
Conversation
Contributor
Author
|
@amercader - when you get a spare mo could you take a look at this please...I should be able to fix the 2.9 failed test over the weekend |
amercader
approved these changes
Apr 11, 2025
Member
|
Makes sense @kowh-ai that was a nasty one |
Contributor
Author
|
CKAN 2.9 failure was just an anomaly - re-ran and finished just fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
For CKAN 2.10 images
When the
build.shscript runs, it initially builds thepython:3.10-slim-bookwormbased image and tags it correctly. However, when it proceeds to build thealpine:3.17based image, it mistakenly tags it with the samepython:3.10-slim-bookwormtag, therefore the tag points to the wrong image.As a result, only the Alpine-based image is tagged.
CKAN 2.9 images has a similar problem