Add model loading failure notifications with i18n support#997
Merged
Conversation
The model loading failure (e.g. ORT error) was only shown as a small red dot with truncated text in the footer. Now it also triggers a toast notification, matching how recording errors are already handled. https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs
Remove the unnecessary modelLoadFailed passthrough key that just forwarded a variable. Use the error string directly with a translated fallback. Add proper translations for all 16 locales. https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs
This was previously left untranslated (English) in all non-English locale files. https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs
DylanBricar
added a commit
to DylanBricar/Phonara
that referenced
this pull request
Mar 11, 2026
Implemented PRs: - cjpais#991: Windows mic permission onboarding (registry + UI) - cjpais#381: Local file transcription (WAV, file picker, 16kHz resampling) - cjpais#704: LLM template variables ($time_local, $date, $language) - cjpais#455: Text replacements (exact find/replace, case-sensitive, 7 tests) - cjpais#874: Custom recordings directory (folder picker + validation) - cjpais#768: Custom audio feedback sounds (wav/mp3/ogg/flac) - cjpais#997: Model loading failure toast notifications (17 locales) - cjpais#996: Russian translation improvements (48 corrections) Fixed issues: - cjpais#199: Whisper initial prompt option (settings + pass-through) - cjpais#858: Partial downloads (stale cleanup + Content-Range validation) - cjpais#921: Clipboard images preserved during paste-via-clipboard - cjpais#502: Clipboard race condition (write-verify-retry + delays) - cjpais#434: Admin window freeze (Windows SendInput replaces enigo) Review fixes: - App.tsx: missing `t` from useTranslation() (runtime crash) - commands/transcription.rs: State<TranscriptionManager> -> State<Arc<TranscriptionManager>> - settings.rs: missing #[serde(default)] on external_script_path - bindings.ts: missing whisper_initial_prompt in AppSettings - settingsStore.ts: missing settingUpdaters for text_replacements, whisper_initial_prompt - shortcut/mod.rs: added update_text_replacements, change_whisper_initial_prompt_setting commands - TextReplacements.tsx: hardcoded "(delete)" -> i18n key - TranscribeFile.tsx: hardcoded "Audio Files" -> i18n key - input.rs: fixed warn macro scope, removed duplicate import - Eliminated all compiler warnings (overlay.rs, signal_handle.rs, shortcut/mod.rs) - Fixed lazy_close_gen race condition in audio manager Co-Authored-By: Claude Opus 4.6 <[email protected]>
fxbenard
pushed a commit
to fxbenard/Parler
that referenced
this pull request
Mar 11, 2026
* fix: show toast notification when model fails to load with ORT error The model loading failure (e.g. ORT error) was only shown as a small red dot with truncated text in the footer. Now it also triggers a toast notification, matching how recording errors are already handled. https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs * fix: add missing i18n keys for model load error toast to all locales https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs * fix: simplify model load error toast and add proper translations Remove the unnecessary modelLoadFailed passthrough key that just forwarded a variable. Use the error string directly with a translated fallback. Add proper translations for all 16 locales. https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs * fix: translate recordingFailed string in all locales This was previously left untranslated (English) in all non-English locale files. https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs * cleanup * format --------- Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
Human Written Description
fixes #713
This PR adds error handling and user feedback for model loading failures. When a model fails to load, the application now listens for the
model-state-changedevent withloading_failedtype and displays a toast notification to the user with the error details. The error messages are fully internationalized across all 18 supported languages, with a fallback generic message when specific error details aren't available.Related Issues/Discussions
Fixes #
Testing
The change adds a new event listener in the App component that responds to model loading failures. Testing should verify:
AI Assistance
If AI was used:
https://claude.ai/code/session_015VfQgoDkUDV6wk63RHrwEs