Add Windows microphone permission onboarding#991
Merged
cjpais merged 2 commits intocjpais:mainfrom Mar 13, 2026
Merged
Conversation
Owner
|
I will test this at the same time as #985 and likely pull both in, thank you! |
DylanBricar
added a commit
to DylanBricar/Phonara
that referenced
this pull request
Mar 11, 2026
Implemented PRs: - cjpais#991: Windows mic permission onboarding (registry + UI) - cjpais#381: Local file transcription (WAV, file picker, 16kHz resampling) - cjpais#704: LLM template variables ($time_local, $date, $language) - cjpais#455: Text replacements (exact find/replace, case-sensitive, 7 tests) - cjpais#874: Custom recordings directory (folder picker + validation) - cjpais#768: Custom audio feedback sounds (wav/mp3/ogg/flac) - cjpais#997: Model loading failure toast notifications (17 locales) - cjpais#996: Russian translation improvements (48 corrections) Fixed issues: - cjpais#199: Whisper initial prompt option (settings + pass-through) - cjpais#858: Partial downloads (stale cleanup + Content-Range validation) - cjpais#921: Clipboard images preserved during paste-via-clipboard - cjpais#502: Clipboard race condition (write-verify-retry + delays) - cjpais#434: Admin window freeze (Windows SendInput replaces enigo) Review fixes: - App.tsx: missing `t` from useTranslation() (runtime crash) - commands/transcription.rs: State<TranscriptionManager> -> State<Arc<TranscriptionManager>> - settings.rs: missing #[serde(default)] on external_script_path - bindings.ts: missing whisper_initial_prompt in AppSettings - settingsStore.ts: missing settingUpdaters for text_replacements, whisper_initial_prompt - shortcut/mod.rs: added update_text_replacements, change_whisper_initial_prompt_setting commands - TextReplacements.tsx: hardcoded "(delete)" -> i18n key - TranscribeFile.tsx: hardcoded "Audio Files" -> i18n key - input.rs: fixed warn macro scope, removed duplicate import - Eliminated all compiler warnings (overlay.rs, signal_handle.rs, shortcut/mod.rs) - Fixed lazy_close_gen race condition in audio manager Co-Authored-By: Claude Opus 4.6 <[email protected]>
(cherry picked from commit 282abc1)
ferologics
force-pushed
the
feat/windows-mic-permission-onboarding-main
branch
from
5aa2dc7 to
0742321
Compare
🧪 Test Build ReadyBuild artifacts for PR #991 are available for testing. Download artifacts from workflow run Artifacts expire after 30 days. |
Owner
|
Tested this earlier and it builds clean, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Windows microphone-permission onboarding flow.
What this does
Privacy & security -> Microphonefrom the onboarding buttonstart_hiddenis enabledContext
This is a follow-up to the Windows mic startup crash fix that was merged in:
Local verification
Tested locally on Windows:
Checks
bun run lintbun run buildcargo check