[macOS] Fix tray icon disabled + start hidden causing app to become permanently invisible #903
Merged
[macOS] Fix tray icon disabled + start hidden causing app to become permanently invisible #903
Conversation
🧪 Test Build ReadyBuild artifacts for PR #903 are available for testing. Download artifacts from workflow run Artifacts expire after 30 days. |
|
please merge this |
Owner
Author
|
@YoussefHachicha have you tested it? |
|
yes its working |
|
Confirmed clicking Handy in the dock brings up the window now. Awesome! Fwiw, I still have |
Owner
Author
|
hmm still not sure what the show tray icon not working, im unable to replicate that and dont see anything obvious |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user disables "Show Tray Icon" in settings and also has "Start Hidden" enabled, the app launches into a completely unreachable state:
The app is running but there is no way to interact with it. The only recovery is re-launching from Spotlight or Applications, which triggers the
single-instance plugin to show the window. But on the next launch, the same invisible state occurs again.
Additionally, macOS had no RunEvent::Reopen handler, so clicking the dock icon (when visible) did nothing to bring the window back.
Fix
now forces the main window to be shown regardless of the start_hidden setting. On macOS, the activation policy is also reset from Accessory to Regular
so the dock icon remains visible.
but has no visible window
TODO: Verify all possible code branches and make sure expectations are aligned for each