fix(nix): address PR #778 review comments#800
Merged
cjpais merged 1 commit intocjpais:mainfrom Feb 13, 2026
Merged
Conversation
- Replace patchShebangs with targeted substituteInPlace for tsc/vite
shebangs, pointing them to bun instead of node
- Use `bun run build` instead of `${pkgs.bun}/bin/bun run build`
since bun is already in nativeBuildInputs
- Remove nodejs from nativeBuildInputs (no longer needed)
- Add comment explaining why doCheck is disabled
pinage404
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
Human Written Description
This addresses the review comments from @pinage404 on #778. The Nix build was using
patchShebangs+nodejswhen it only needed to fix two shebangs (tscandvite), and was using the full store path forbun. Comments added for explanations in some areas too.Related Issues/Discussions
Follow-up to #778 (review comments)
Community Feedback
@pinage404 left 5 review comments on #778 that were merged without being addressed. This PR resolves them:
Add comment explaining platform restriction— no longer applicable, PR fix(nix): fix ALSA mismatch, add GStreamer plugins, and repair UI environment #787 addedaarch64-linuxtosupportedSystemsnodejsdependency — replacedpatchShebangswith targetedsubstituteInPlacebunfor shebangs instead ofnode—tsc/viteshebangs now point tobunbun run buildinstead of${pkgs.bun}/bin/bun run build—bunis already on PATHdoCheck = false— documents sandbox limitationsTesting
nix build .#handycompletes successfullyresult/bin/handybinary exists and is executableldd result/bin/handy— all shared libraries resolvenix path-info -r .#handy | grep -i node— returns nothing (nodejs not in closure)Screenshots/Videos (if applicable)
N/A
AI Assistance
If AI was used: