feat: configurable custom audio feedback sounds#768
Closed
boeserwolf wants to merge 2 commits intocjpais:mainfrom
Closed
feat: configurable custom audio feedback sounds#768boeserwolf wants to merge 2 commits intocjpais:mainfrom
boeserwolf wants to merge 2 commits intocjpais:mainfrom
Conversation
6 tasks
Owner
|
I'll review this when I get a chance, but if you could, could you rebase? |
boeserwolf
force-pushed
the
feature/custom-audio-feedback-files
branch
from
739c925 to
05afcc4
Compare
boeserwolf
force-pushed
the
feature/custom-audio-feedback-files
branch
from
05afcc4 to
bde43cd
Compare
Contributor
Author
|
Thanks a lot! Rebase is ready. |
DylanBricar
added a commit
to DylanBricar/Phonara
that referenced
this pull request
Mar 11, 2026
Implemented PRs: - cjpais#991: Windows mic permission onboarding (registry + UI) - cjpais#381: Local file transcription (WAV, file picker, 16kHz resampling) - cjpais#704: LLM template variables ($time_local, $date, $language) - cjpais#455: Text replacements (exact find/replace, case-sensitive, 7 tests) - cjpais#874: Custom recordings directory (folder picker + validation) - cjpais#768: Custom audio feedback sounds (wav/mp3/ogg/flac) - cjpais#997: Model loading failure toast notifications (17 locales) - cjpais#996: Russian translation improvements (48 corrections) Fixed issues: - cjpais#199: Whisper initial prompt option (settings + pass-through) - cjpais#858: Partial downloads (stale cleanup + Content-Range validation) - cjpais#921: Clipboard images preserved during paste-via-clipboard - cjpais#502: Clipboard race condition (write-verify-retry + delays) - cjpais#434: Admin window freeze (Windows SendInput replaces enigo) Review fixes: - App.tsx: missing `t` from useTranslation() (runtime crash) - commands/transcription.rs: State<TranscriptionManager> -> State<Arc<TranscriptionManager>> - settings.rs: missing #[serde(default)] on external_script_path - bindings.ts: missing whisper_initial_prompt in AppSettings - settingsStore.ts: missing settingUpdaters for text_replacements, whisper_initial_prompt - shortcut/mod.rs: added update_text_replacements, change_whisper_initial_prompt_setting commands - TextReplacements.tsx: hardcoded "(delete)" -> i18n key - TranscribeFile.tsx: hardcoded "Audio Files" -> i18n key - input.rs: fixed warn macro scope, removed duplicate import - Eliminated all compiler warnings (overlay.rs, signal_handle.rs, shortcut/mod.rs) - Fixed lazy_close_gen race condition in audio manager Co-Authored-By: Claude Opus 4.6 <[email protected]>
Owner
|
Okay, I'm sorry, I just don't really have time to accept new features and ones that potentially could introduce bugs. I don't think that this is a bad change, but maybe it's something we can pick up in the future. I just need to kind of clean out my PRs so I have a little less to focus on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
If this is a feature or change that was previously closed/rejected:
Human Written Description
I wanted to keep Handy’s existing audio feedback behavior, but make it possible to use personal sounds for recording start and stop.
This adds optional custom start/stop sound file selection in settings without removing the built-in sound themes.
The goal is to make feedback sounds more flexible while keeping the default flow unchanged for existing users.
Related Issues/Discussions
Fixes #
Discussion:
Community Feedback
No separate discussion thread yet.
This change was tested directly in a real Linux desktop workflow and is backward compatible with existing sound themes.
Testing
Start.Stop.tauri build+ AppImage run).Screenshots/Videos (if applicable)
N/A
AI Assistance
If AI was used:
gpt-5.3-codex)