fix: tooltip overflow at window boundaries#538
Merged
cjpais merged 1 commit intocjpais:mainfrom Jan 10, 2026
Merged
Conversation
Owner
|
omg thank you, im excited to review this code. this has been bugging me for ages but other higher priority issues have taken my attention! |
h0lybyte
added a commit
to KBVE/Handy
that referenced
this pull request
Jan 12, 2026
…, and UI improvements Merged upstream features: - feat: add Czech translation (cjpais#568) - fix: keybinding changes failing silently due to incorrect key ordering (cjpais#524) - fix: improve apple intelligence ui and add reusable alert component (cjpais#517) - Fix race condition when toggling transcription via SIGUSR2 (cjpais#560) - feat(linux): add ydotool support for text input (cjpais#557) - feat: add Moonshine Base speech recognition model (cjpais#556) - Prevent highlight and selection cursor hover on UI text items (cjpais#541) - feat(ui): add reusable Tooltip component and integrate with settings (cjpais#538) - PR guidelines for AI - dont allow package-lock with a bun project for now Conflicts resolved: - src-tauri/src/shortcut.rs: Kept KBVE filler detection commands, adopted upstream's improved doc comment - src/bindings.ts: Merged KBVE types (Discord, Memory, Filler) with upstream's Moonshine engine type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
Human Written Description
Tooltips were clipped by parent overflow-hidden containers, making text unreadable at window edges. Fixed by using a React Portal to render tooltips at the document root, so they always appear fully visible.
Related Issues/Discussions
Testing
Screenshots/Videos (if applicable)
Before
After
Technical Summary
Problem
Tooltips were rendered inside containers with
overflow-hidden, causing them to be clipped at window boundaries.Solution
Tooltip.tsxcomponent using React Portal (createPortal)document.bodyto escape overflow constraintsChanges
src/components/ui/Tooltip.tsxsrc/components/ui/SettingContainer.tsxsrc/components/ui/index.ts