Skip to content

fix: improve apple intelligence ui and add reusable alert component#517

Merged
cjpais merged 1 commit intocjpais:mainfrom
VirenMohindra:vm/apple-intelligence-ui-cleanup
Jan 10, 2026
Merged

fix: improve apple intelligence ui and add reusable alert component#517
cjpais merged 1 commit intocjpais:mainfrom
VirenMohindra:vm/apple-intelligence-ui-cleanup

Conversation

@VirenMohindra
Copy link
Copy Markdown
Contributor

@VirenMohindra VirenMohindra commented Jan 4, 2026

Before Submitting This PR

Please confirm you have done the following:

Human Written Description

  • follow up PR to update the UI design for the error state, have two states, contained to handle border radius, added icon(s), and an alert UI component to standardize approach

Related Issues/Discussions

Community Feedback

requested by @cjpais in #473

Testing

  • tested apple intelligence selection with feature unavailable - error displays correctly
  • tested apple intelligence selection with feature available - no error shown
  • verified model dropdown is hidden when apple intelligence is selected
  • lint and format checks pass

Screenshots/Videos (if applicable)

Description Screenshot
when apple intelligence works apple-intelligence works
selected "custom" custom
refreshed error state error-state

- hide model dropdown when apple intelligence is selected
- move error state into provider section (only shows when unavailable)
- remove redundant apple intelligence infobox
- add reusable Alert component with variants (error, warning, info, success)
- Alert supports contained prop for use inside settings groups
@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Jan 4, 2026

Thank you!

@VirenMohindra
Copy link
Copy Markdown
Contributor Author

@cjpais are you looking for something specific? I wasn't entirely sure what you meant by improving the UI, so i went with my gut and made fixes to things-i-wanted-to-change

@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Jan 4, 2026

I'll probably just need to take a look at it myself, this fixes most of my pain points I think

I just wanted to get the primary fix out since I got some emails I think that PR will solve

@cjpais cjpais merged commit 5da4951 into cjpais:main Jan 10, 2026
2 checks passed
h0lybyte added a commit to KBVE/Handy that referenced this pull request Jan 12, 2026
…, and UI improvements

Merged upstream features:
- feat: add Czech translation (cjpais#568)
- fix: keybinding changes failing silently due to incorrect key ordering (cjpais#524)
- fix: improve apple intelligence ui and add reusable alert component (cjpais#517)
- Fix race condition when toggling transcription via SIGUSR2 (cjpais#560)
- feat(linux): add ydotool support for text input (cjpais#557)
- feat: add Moonshine Base speech recognition model (cjpais#556)
- Prevent highlight and selection cursor hover on UI text items (cjpais#541)
- feat(ui): add reusable Tooltip component and integrate with settings (cjpais#538)
- PR guidelines for AI
- dont allow package-lock with a bun project for now

Conflicts resolved:
- src-tauri/src/shortcut.rs: Kept KBVE filler detection commands, adopted upstream's improved doc comment
- src/bindings.ts: Merged KBVE types (Discord, Memory, Filler) with upstream's Moonshine engine type
@VirenMohindra VirenMohindra deleted the vm/apple-intelligence-ui-cleanup branch March 19, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants