feat: add double-click support for tray icon#369
Conversation
|
Hm is the manual click tracking necessary considering Tauri has the built in double click event? |
I tried with the double click event, but it fired for a single click then for me 🤔 |
|
This doesn't seem to change any behaviour on macOS, which is probably correct because I wouldn't expect a menubar item to open an app's settings window. The current behaviour (opening a menu) is pretty normal for this kinda app. |
|
Yea for macOS I don't think apps usually have a double click event in the top tray thing. It's mostly a windows thing but pretty common.
Do you mean the menu shows with a single left click, or it made it fire the double-click app just when left clicking once? @olejsc If the former I bet it is because of this line: Even if it's the latter it might be interfering with the event somehow. Probably better to just set that to false in any case, if the double left click event is added. I assume right click will still show the menu. |
|
@olejsc any chance you could look at this? I would like to merge and clear this PR out |
🧪 Test Build ReadyBuild artifacts for PR #369 are available for testing. Download artifacts from workflow run Artifacts expire after 30 days. |
- PR cjpais#944: Volume slider now uses 1% step instead of 10% - PR cjpais#369: Double-click tray icon opens main window - PR cjpais#477: App no longer crashes when no microphone is connected (graceful fallback to on-demand mode) - Issue cjpais#858: Corrupt/empty model downloads are detected and re-downloaded automatically instead of blocking future download attempts - Issue cjpais#315: Overlay no longer steals focus on Windows (WS_EX_NOACTIVATE + WS_EX_TOOLWINDOW + WS_EX_TRANSPARENT) - Issue cjpais#263: Overlay size now uses logical coordinates for correct DPI scaling on high-DPI displays (150%+) - Fix log filename from 'parler' to 'phonara' Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
It would be cool to see this PR in the main , because on Windows it is very strange to click with the left button and get a menu instead of seeing an open program. |
|
▎ hey, i tested this on macOS (arm64, macOS 26.2) with some automated tray interaction tests~ with current code (
with
so the core issue is exactly what @ThioJoe called out... also worth noting: couple of key issues to resolve before merge~
happy to open a follow-up PR with these fixes if @olejsc is unavailable — the changes are small once direction is decided |
|
@VirenMohindra @cjpais apologies, I planned to do this but forgot completely about it. Please @VirenMohindra feel free to tweak & adjust the PR if you have the time, I'm currently quite busy so I dont have the time to look at it. Excellent job testing ( I dont own a Mac). |
- SHA256 download verification to prevent corrupt partial download loops (cjpais#1095) - Secondary transcription shortcut with independent language setting (cjpais#1106) - Double-click tray icon to show main window (cjpais#369) - CLI --auto-submit flag to force enter after transcription (cjpais#1099) - OCR template context via ${OCR} variable in post-processing prompts (cjpais#770)
Adds double click support to open application from system tray.
Tested locally on Windows
NOT tested on MacOS. Code for that is experimental. Would be neat if someone on MacOS could verify that it works.
Ref. discussion #368
Simple GIF demo:

I dont know if this is desired behaviour, as the auther hasn't expressed any opinions on this. Feel free to reject if this is out of scope for the application 😊
Disclaimer; the code changes was made partially with AI support.