fix(issue 522): surface paste errors as UI toast notification#1198
Open
odedindi wants to merge 2 commits intocjpais:mainfrom
Open
fix(issue 522): surface paste errors as UI toast notification#1198odedindi wants to merge 2 commits intocjpais:mainfrom
odedindi wants to merge 2 commits intocjpais:mainfrom
Conversation
When pasting the transcription fails (e.g. wtype/xdotool/dotool not available or returns an error on Linux), the error was silently logged to the backend console only. Users had no idea why their text was not pasted. Emit a new 'paste-error' Tauri event from the Rust side and listen for it in the frontend App component, showing a sonner toast with the error detail — mirroring the existing 'recording-error' pattern exactly. Files changed: - src-tauri/src/actions.rs: add PasteErrorEvent struct, emit event on paste failure - src/App.tsx: add useEffect listener that shows toast.error on paste-error - src/lib/types/events.ts: add PasteErrorEvent interface - src/i18n/locales/en/translation.json: add pasteFailedTitle/pasteFailed keys
Owner
|
ill take a look when I get a chance, probably a good thing to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Written Description
I was looking for a good first issue to start with in this repo, and from several issues I had Claude filter for me this issue seemed straight forward.
I basically extended the existing 'RecordingErrorEvent' error handling pattern.
This MR does not actually resolve or fixes the original issue described but at least now users will be notified on such errors
Related Issues/Discussions
Fixes #522
Discussion:
Testing
Verified with:
bun run build— TypeScript cleancargo check— cleanbun run lint— ESLint cleancargo fmt+prettier— formatting appliedLive paste-failure testing requires Linux with a broken paste tool (wtype/xdotool/dotool). I don't have a Linux environment available and it would be great to have a Linux contributor verify the toast appears end-to-end.
AI Assistance