fix(ci): use sign-binaries: true in main-build.yml#1094
Merged
cjpais merged 1 commit intocjpais:mainfrom Mar 19, 2026
Merged
Conversation
sign-binaries: false passes empty strings for TAURI_SIGNING_PRIVATE_KEY and APPLE_CERTIFICATE, but Tauri treats a set-but-empty env var as a signing attempt, causing all builds to fail. Use sign-binaries: true to match pr-test-build.yml — secrets are already configured in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Human Written Description
All 7 platform builds in the new main-build.yml were failing. The cause:
sign-binaries: falsepasses empty strings forTAURI_SIGNING_PRIVATE_KEYandAPPLE_CERTIFICATEas env vars. Tauri treats a set-but-empty env var as a signing attempt and immediately fails trying to decode/import the key. On macOS:failed to import keychain certificate. On Linux:failed to decode secret key: Missing comment in secret key. Windows ARM64 failed for the same reason on top of a separate missing bundler issue.This code path was never exercised before —
pr-test-build.ymlalways usessign-binaries: true. Fix is to match that behavior. Secrets are already configured in the repo and signed artifacts are actually installable for testing, which is the point.Related Issues/Discussions
Follow-up to #1092 (which itself followed #1091)
Testing
AI Assistance
AI was used
Tools used: Claude Code
How extensively: diagnosed from CI logs, wrote the one-line fix